Skip to content

fix quickstyle: run golangci-lint in the repo you invoked it from #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikin91 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix quickstyle: run golangci-lint in the repo you invoked it from #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/dev/quickstyle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,9 @@ function gostyle() {
local golangci_lint_bin
golangci_lint_bin="$(resolve_tool_path golangci-lint)" || golangci_lint_bin=""
if [[ -n "${golangci_lint_bin}" && -x "${golangci_lint_bin}" ]]; then
"${golangci_lint_bin}" run --allow-parallel-runners "${godirs[@]}" --fix && (( status == 0 ))
# cd here and drop the gitroot prefix so we lint this clone, like CI.
local prefix="${gitroot}/"
(cd "${gitroot}" && "${golangci_lint_bin}" run --allow-parallel-runners "${godirs[@]#"$prefix"}" --fix) && (( status == 0 ))
status=$?
else
ewarn "No golangci-lint binary found, but the repo has a config file. Skipping..."
Expand Down
Loading