Skip to content

ROX-36566: Make filterChipLabel consistent for CVSS search field - #22459

Open
pedrottimark wants to merge 1 commit into
masterfrom
ROX-36566-filterChipLabel-CVSS
Open

ROX-36566: Make filterChipLabel consistent for CVSS search field#22459
pedrottimark wants to merge 1 commit into
masterfrom
ROX-36566-filterChipLabel-CVSS

Conversation

@pedrottimark

Copy link
Copy Markdown
Contributor

Description

Problem

During homework to factor out search filter config as single source of truth for Results and Reports routes, especially in node vulnerability reports, I found:

  • imageCVE.ts file has filterChipLabel: 'CVSS'
  • nodeCVE and platformCVE.ts files have: filterChipLabel: 'CVE CVSS'

Analysis

No search results in cypress folder.

Solution

Be consistent. Confirmed the change in acs-ux channel.

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder.
  2. npm run lint:fast-dev in ui/apps/platform folder.

@pedrottimark
pedrottimark requested a review from dvail August 25, 2026 20:18
@pedrottimark
pedrottimark requested a review from a team as a code owner August 25, 2026 20:18
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 53c0256d-14f1-4d9f-b54f-dffc71e7682a

📥 Commits

Reviewing files that changed from the base of the PR and between 96307cf and ed4051a.

📒 Files selected for processing (2)
  • ui/apps/platform/src/Components/CompoundSearchFilter/attributes/nodeCVE.ts
  • ui/apps/platform/src/Components/CompoundSearchFilter/attributes/platformCVE.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Updated CVSS filter labels to display as “CVSS” for clearer, more concise filtering.

Walkthrough

The CVSS filter chip label changes from CVE CVSS to CVSS for node and platform CVE attributes.

Changes

CVSS filter labels

Layer / File(s) Summary
Update CVSS filter chip labels
ui/apps/platform/src/Components/CompoundSearchFilter/attributes/nodeCVE.ts, ui/apps/platform/src/Components/CompoundSearchFilter/attributes/platformCVE.ts
Both CVE attribute definitions now use CVSS for the filter chip label.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ed405

The change standardizes the CVSS filter label across affected routes without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: dvail

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the consistency update to the CVSS search field filter label and references the related tracking issue.
Description check ✅ Passed The description explains the problem, solution, documentation impact, production readiness, and validation steps. CI inspection and automated test checks remain unchecked, but these omissions are non-…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, solution, documentation impact, production readiness, and validation steps. CI inspection and automated test checks remain unchecked, but these omissions are non-critical for this small label-only change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ROX-36566-filterChipLabel-CVSS

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.38%. Comparing base (96307cf) to head (ed4051a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22459      +/-   ##
==========================================
- Coverage   51.39%   51.38%   -0.02%     
==========================================
  Files        2869     2869              
  Lines      179862   179862              
==========================================
- Hits        92443    92415      -28     
- Misses      79314    79327      +13     
- Partials     8105     8120      +15     
Flag Coverage Δ
go-unit-tests 51.38% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit ed4051a. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.x-66-ged4051aeb8

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown

@pedrottimark: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests ed4051a link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/gke-ui-e2e-tests ed4051a link true /test gke-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant