ROX-36566: Make filterChipLabel consistent for CVSS search field - #22459
ROX-36566: Make filterChipLabel consistent for CVSS search field#22459pedrottimark wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe CVSS filter chip label changes from ChangesCVSS filter labels
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change standardizes the CVSS filter label across affected routes without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the problem, solution, documentation impact, production readiness, and validation steps. CI inspection and automated test checks remain unchecked, but these omissions are non-critical for this small label-only change. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22459 +/- ##
==========================================
- Coverage 51.39% 51.38% -0.02%
==========================================
Files 2869 2869
Lines 179862 179862
==========================================
- Hits 92443 92415 -28
- Misses 79314 79327 +13
- Partials 8105 8120 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 Build Images ReadyImages are ready for commit ed4051a. To use with deploy scripts: export MAIN_IMAGE_TAG=5.0.x-66-ged4051aeb8 |
|
@pedrottimark: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Problem
During homework to factor out search filter config as single source of truth for Results and Reports routes, especially in node vulnerability reports, I found:
filterChipLabel: 'CVSS'filterChipLabel: 'CVE CVSS'Analysis
No search results in cypress folder.
Solution
Be consistent. Confirmed the change in acs-ux channel.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.