-
Notifications
You must be signed in to change notification settings - Fork 0
Set berserker config via url #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoukoVirtanen
wants to merge
16
commits into
main
Choose a base branch
from
jv-set-berserker-config-via-url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a6b13f2
X-Smart-Branch-Parent: main
JoukoVirtanen 6579dab
Setting berserker config paths
JoukoVirtanen 2645462
Setting berserker url
JoukoVirtanen 372689f
Should used kube-burner config in kube-burner-ocp
JoukoVirtanen f1d98be
Switched from BERSERKER_DAEMONSET_TEMPLATE to BERSERKER_CONTAINERS_FILE
JoukoVirtanen 421d715
Set lifespan to 6h
JoukoVirtanen 6853b68
Updated kube-burner version to 2.6.2
JoukoVirtanen 206b140
Updated init command for new kube-burner version
JoukoVirtanen 338cf40
Updated index command
JoukoVirtanen b2df10e
Updated BERSERKER_CONFIGMAP_TEMPLATE
JoukoVirtanen 45b0219
Set additional environment variables in the kube-burner pod
JoukoVirtanen f9f5cd9
Setting more env vars which have been added to kube-burner-ocp
JoukoVirtanen 69b0bc8
Using --user-data instead of --set
JoukoVirtanen 183cddc
Set POD_READY_THRESHOLD to 0 and CHURN_DURATION to 1000h
JoukoVirtanen 9110015
Churn at the namespace level
JoukoVirtanen d87b92f
Updated kube-burner-ocp branch
JoukoVirtanen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
Checkout missing
persist-credentials: false.Static analysis (zizmor) flags this checkout for credential persistence via
GITHUB_TOKENon disk (artipacked). Since artifacts/workspace can be exposed downstream, consider disabling credential persistence unless it's needed by a later step.Suggested fix
- name: Check out berserker config repository code uses: actions/checkout@v4 with: repository: ${{ inputs.berserker-config-repo }} path: .berserker-config ref: ${{ inputs.berserker-config-ref }} + persist-credentials: false📝 Committable suggestion
🧰 Tools
🪛 zizmor (1.26.1)
[warning] 483-489: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents
Source: Linters/SAST tools