Skip to content

Remove inspector and add agent to enabled_inspect_interfaces for baremetal mixin - #2536

Merged
claudia-lola merged 1 commit into
stackhpc/2026.1from
fix-ironic-conductor-error
Aug 24, 2026
Merged

Remove inspector and add agent to enabled_inspect_interfaces for baremetal mixin#2536
claudia-lola merged 1 commit into
stackhpc/2026.1from
fix-ironic-conductor-error

Conversation

@claudia-lola

@claudia-lola claudia-lola commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Deploying the baremetal mixin, ironic_conductor container would show as unhealthy. docker logs show error:

  File "/var/lib/kolla/venv/lib64/python3.12/site-packages/ironic/common/driver_factory.py", line 381, in _missing_callback
    raise exception.DriverNotFoundInEntrypoint(
ironic.common.exception.DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.inspect' entrypoint: inspector.

Which relates to the removal of standalone Ironic inspector. To fix, removed inspector and added agent to list for kolla_enabled_inspect_interfaces resolved the error. ironic_conductor container deploys healthy.

@claudia-lola
claudia-lola requested a review from a team as a code owner August 24, 2026 10:16
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d331af65-7efd-47ec-afa4-fd2d55dcd29a

📥 Commits

Reviewing files that changed from the base of the PR and between e6c050b and 06b319d.

📒 Files selected for processing (1)
  • etc/kayobe/environments/baremetal/ironic.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: stackhpc/check
  • GitHub Check: Ansible 2.19 lint with Python 3.12
  • GitHub Check: Ansible 2.20 lint with Python 3.12
🔇 Additional comments (1)
etc/kayobe/environments/baremetal/ironic.yml (1)

52-52: LGTM!


📝 Walkthrough

Updates the baremetal Ironic configuration to use the agent inspect interface instead of inspector. The no-inspect interface remains enabled.

Walkthrough

The bare-metal Ironic configuration now enables the agent inspect interface instead of inspector. The no-inspect interface remains enabled.

Changes

Ironic inspection configuration

Layer / File(s) Summary
Update enabled inspect interface
etc/kayobe/environments/baremetal/ironic.yml
The configuration replaces inspector with agent in the enabled inspect interfaces. It retains no-inspect.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 06b31

This is a localized configuration change that removes the inspector and enables the agent for the baremetal mixin. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claudia-lola
claudia-lola merged commit 7fa8c88 into stackhpc/2026.1 Aug 24, 2026
29 of 30 checks passed
@claudia-lola
claudia-lola deleted the fix-ironic-conductor-error branch August 24, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants