ci: install a prebuilt cargo-audit before the security audit - #3
Merged
Merged
Conversation
rustsec/audit-check does not ship cargo-audit. It looks the binary up on PATH and, on a miss, falls back to a bare `cargo install cargo-audit` with no `--locked`, so the install resolves cargo-audit's dependency graph fresh. That now pulls in kstring 2.0.4, whose MSRV is 1.96.0, while rust-toolchain.toml pins this repository to 1.95.0, and the daily job fails before it ever reads an advisory. The action exposes no way to pass `--locked`, but it does skip the install when the binary is already present, so install a prebuilt cargo-audit first. This uses the same taiki-e/install-action pin that build.yaml already uses for cargo-deny, cargo-sort and cargo-fuzz, and it also drops the aws-lc-sys build from the job. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
adwk67
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The daily security audit has been failing before it reads a single advisory.
rustsec/audit-checkdoes not shipcargo-audit. It looks the binary up onPATHand, on a miss, falls back to a barecargo install cargo-auditwith no--locked, so the install resolves cargo-audit's dependency graph fresh ratherthan from its published lockfile. That now pulls in
kstring 2.0.4, whose MSRVis 1.96.0, while
rust-toolchain.tomlpins this repository to 1.95.0:The action exposes no input for
--locked, but itsfindOrInstallhelper skipsthe install entirely when the binary is already present. So this installs a
prebuilt
cargo-auditfirst, using the sametaiki-e/install-actionpinbuild.yamlalready uses for cargo-deny, cargo-sort and cargo-fuzz. Nothing iscompiled, the toolchain pin no longer constrains a tool that only reads
Cargo.lock, and the aws-lc-sys build drops out of the job.