Skip to content

fix: display icons on local builds #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xeniape merged 1 commit into from
Aug 4, 2026
Merged

fix: display icons on local builds #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion antora-playbook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ asciidoc:
attributes:
base-repo: https://github.com/stackabletech
# an external icon. Create a link opening in a new tab like this: http://my-url.com[Text {external-link-icon}^]
external-link-icon: "<svg class=\"svg-icon\" style=\"width: 0.75em; height: 0.75em; margin-left: 3px;\" aria-hidden=\"true\"><use href=\"/_/img/icons.svg#icon-external-link\"/></svg>"
external-link-icon: "<svg class=\"svg-icon\" style=\"width: 0.75em; height: 0.75em; margin-left: 3px;\" aria-hidden=\"true\"><use href=\"#icon-external-link\"/></svg>"
# the default caching directory is ./.cache/antora
# Antora caches the git repos, this can sometimes lead to stale content
# use 'make clean' to remove the build and cache directory
Expand Down
2 changes: 1 addition & 1 deletion local-antora-playbook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ asciidoc:
attributes:
base-repo: https://github.com/stackabletech
# an external icon. Create a link opening in a new tab like this: http://my-url.com[Text {external-link-icon}^]
external-link-icon: "<svg class=\"svg-icon\" style=\"width: 0.75em; height: 0.75em; margin-left: 3px;\" aria-hidden=\"true\"><use href=\"/_/img/icons.svg#icon-external-link\"/></svg>"
external-link-icon: "<svg class=\"svg-icon\" style=\"width: 0.75em; height: 0.75em; margin-left: 3px;\" aria-hidden=\"true\"><use href=\"#icon-external-link\"/></svg>"
# the default caching directory is ./.cache/antora
# Antora caches the git repos, this can sometimes lead to stale content
# use 'make clean' to remove the build and cache directory
Expand Down
2 changes: 1 addition & 1 deletion modules/reference/pages/glossary.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
= Glossary
:li: pass:[<svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="/_/img/icons.svg#icon-link"/></svg>]
:li: pass:[<svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="#icon-link"/></svg>]
:description: Glossary of Stackable terms, including Role, Role Group, and Stacklet, with definitions and links to detailed explanations.

// refined styling for the glossary
Expand Down
2 changes: 1 addition & 1 deletion only-dev-antora-playbook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ asciidoc:
attributes:
base-repo: https://github.com/stackabletech
# an external icon. Create a link opening in a new tab like this: http://my-url.com[Text {external-link-icon}^]
external-link-icon: "<svg class=\"svg-icon\" style=\"width: 0.75em; height: 0.75em; margin-left: 3px;\" aria-hidden=\"true\"><use href=\"/_/img/icons.svg#icon-external-link\"/></svg>"
external-link-icon: "<svg class=\"svg-icon\" style=\"width: 0.75em; height: 0.75em; margin-left: 3px;\" aria-hidden=\"true\"><use href=\"#icon-external-link\"/></svg>"
# the default caching directory is ./.cache/antora
# Antora caches the git repos, this can sometimes lead to stale content
# use 'make clean' to remove the build and cache directory
Expand Down
8 changes: 4 additions & 4 deletions supplemental-ui/partials/navbar.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<a class="navbar-item" href="{{{ relativize (versioned "home" page "reference/index.html") }}}">CRD Reference</a>
{{else}}
<a class="navbar-item" href="{{{ page.attributes.crd-docs }}}" target="_blank">
CRD Reference <svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-external-link"/></svg>
CRD Reference <svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="#icon-external-link"/></svg>
</a>
{{/if}}
<hr class="navbar-divider">
Expand Down Expand Up @@ -95,13 +95,13 @@
<a class="navbar-link" href="#">Community</a>
<div class="navbar-dropdown">
<a class="navbar-item" href="https://stackable.tech/en/" target="_blank">
Homepage <svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-external-link"/></svg>
Homepage <svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="#icon-external-link"/></svg>
</a>
<a class="navbar-item" href="https://github.com/stackabletech/" target="_blank">
GitHub <svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-external-link"/></svg>
GitHub <svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="#icon-external-link"/></svg>
</a>
<a class="navbar-item" href="https://discord.com/invite/7kZ3BNnCAF" target="_blank">
Discord <svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-external-link"/></svg>
Discord <svg class="svg-icon" style="width: 0.875em; height: 0.875em; margin-left: 5px;" aria-hidden="true"><use href="#icon-external-link"/></svg>
</a>
<hr class="navbar-divider">
<a class="navbar-item" href="{{{ relativize (versioned "home" page "contributor/index.html") }}}">Contributing</a>
Expand Down
2 changes: 1 addition & 1 deletion truly-local-playbook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ asciidoc:
attributes:
base-repo: https://github.com/stackabletech
# an external icon. Create a link opening in a new tab like this: http://my-url.com[Text {external-link-icon}^]
external-link-icon: "<svg class=\"svg-icon\" style=\"width: 0.75em; height: 0.75em; margin-left: 3px;\" aria-hidden=\"true\"><use href=\"/_/img/icons.svg#icon-external-link\"/></svg>"
external-link-icon: "<svg class=\"svg-icon\" style=\"width: 0.75em; height: 0.75em; margin-left: 3px;\" aria-hidden=\"true\"><use href=\"#icon-external-link\"/></svg>"
# the default caching directory is ./.cache/antora
# Antora caches the git repos, this can sometimes lead to stale content
# use 'make clean' to remove the build and cache directory
Expand Down
1 change: 1 addition & 0 deletions ui/src/layouts/404.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{{> head defaultPageTitle='Page Not Found'}}
</head>
<body class="status-404">
{{> icons}}
{{> universal-nav}}
{{> header}}
{{> body}}
Expand Down
1 change: 1 addition & 0 deletions ui/src/layouts/default.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{{> head defaultPageTitle='Untitled'}}
</head>
<body class="article{{#with (or page.attributes.role page.role)}} {{{this}}}{{/with}}">
{{> icons}}
{{> universal-nav}}
{{> header}}
{{> body}}
Expand Down
1 change: 1 addition & 0 deletions ui/src/layouts/landing.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{{> head defaultPageTitle='Untitled'}}
</head>
<body class="article{{#with (or page.attributes.role page.role)}} {{{this}}}{{/with}}">
{{> icons}}
{{> universal-nav}}
{{> header}}
<div class="body">
Expand Down
8 changes: 4 additions & 4 deletions ui/src/partials/footer-content.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,16 @@
<div>© 2025 Stackable.</div>
<div class="social-icons-container">
<a class="social-icon" href="https://www.xing.com/pages/stackable" target="_blank">
<svg class="svg-icon" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-xing"/></svg>
<svg class="svg-icon" aria-hidden="true"><use href="#icon-xing"/></svg>
</a>
<a class="social-icon" href="https://www.linkedin.com/company/stackabletech/" target="_blank">
<svg class="svg-icon" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-linkedin"/></svg>
<svg class="svg-icon" aria-hidden="true"><use href="#icon-linkedin"/></svg>
</a>
<a class="social-icon" href="https://github.com/stackabletech" target="_blank">
<svg class="svg-icon" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-github"/></svg>
<svg class="svg-icon" aria-hidden="true"><use href="#icon-github"/></svg>
</a>
<a class="social-icon" href="https://twitter.com/stackabletech" target="_blank">
<svg class="svg-icon" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-twitter"/></svg>
<svg class="svg-icon" aria-hidden="true"><use href="#icon-twitter"/></svg>
</a>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/partials/header.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<span></span>
</button>
<div id="search-button" class="navbar-item">
<svg class="svg-icon" aria-hidden="true"><use href="{{{uiRootPath}}}/img/icons.svg#icon-search"/></svg>
<svg class="svg-icon" aria-hidden="true"><use href="#icon-search"/></svg>
<div id="search-background"></div>
<div id="search">
<div id="search-input"></div>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/img/icons.svg → ui/src/partials/icons.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<svg xmlns="http://www.w3.org/2000/svg" style="display: none;">
<svg xmlns="http://www.w3.org/2000/svg" style="display: none;" aria-hidden="true">
<!--
Icon path data from Font Awesome Free 6.2.1 (https://fontawesome.com),
licensed under CC BY 4.0 (https://fontawesome.com/license/free).
Expand Down
Loading