Feat/s3 file browser v1 by dklOrdix · Pull Request #208 · stackabletech/cockpit

dklOrdix · 2026-06-18T11:08:13Z

Closes #129

…in +layout.svelte

…ebar imports Co-authored-by: Copilot <copilot@github.com>

Co-authored-by: Copilot <copilot@github.com>

…s/utils Co-authored-by: Copilot <copilot@github.com>

Co-authored-by: Copilot <copilot@github.com>

feat(storage): initial Filebrowser UI implementation

Co-authored-by: Copilot <copilot@github.com>

…ation S3 File Browser Page Navigation (Pagination)

* #96 disable the storage browser if feature flag is set * #96 fix svelte-check * #96 fix lint * #96 disable storage browser by default

* #102 refactor pagination controls into a separate component * #102 simplified pagination props

* #93 add modal preview for file display * #93 fix broken e2e tests * #93 add preview for parquet files, fix scrollbar visibility in preview, allow ms excel csv data for preview * #93 improve parquet row fetch handling * #93 fix lint * #93 move preview endpoint logic into separate files * #93 disable parquet preview

* refactor(ObjectTable): extract File and Folde rows into seperate components * style: format code * style: use camelCase * style: use camelCase

* feat: implement single-file download functionality and error handling for S3 storage * feat: refactor S3 download endpoint to use new API structure and improve error handling * chore: remove obsolete note about static download route segment in tech debt documentation * style: format code * fix: improve type safety in S3 error handling * fix: preview action * feat: add context menu header and improve file selection handling in FileExplorer * fix: reset selection state on context menu close and refine download action logic * style: format files * style: remove pointer events from Actions row on ContextMenu * #91 fix lint --------- Co-authored-by: F3l1x1vo <fli@ordix.de>

Bohreromir

A lot of the Playwright tests fail for me, do they for you too?

Here is some claude as a starting point:

storage/preview.spec.ts — PDF preview: timed out waiting for tbody tr or "This bucket is empty" after navigating to a bucket route.
storage/recent-items.spec.ts — removes a deleted file from Recent Files: timed out (60s, ×3 attempts via retries) waiting for the "Toggle selection mode" button.
storage/recent-items.spec.ts — removes files/location when a directory is deleted: Error: Channel closed / browser already closed mid-action.

The screenshots are the key clue. In both failures #1 and #2, the captured screenshot shows the Storage overview page (bucket card grid + Recent Files tab) — not the bucket browsing page the test expected. So page.goto(bucketRoute(...)) is redirecting back to /storage instead of opening the bucket.

This is masked by a bug in the test helper waitForObjectsLoaded() (e2e/storage/helpers.ts:185-192): it waits for tbody tr or "This bucket is empty" as a generic "did objects load" signal. But the Storage overview page's Recent Files tab also renders a

, so when the redirect happens and Recent Files has an entry, that locator matches by coincidence — the helper reports success on the wrong page. The test then tries to click "Toggle selection mode" (a bucket-only control), which never appears, and burns the full 60s test.slow() timeout, ×2 retries.

Bohreromir

Please also fix the new lint warnings introduced:

security/detect-non-literal-fs-filename (11)
- src/architecture/code-size-limits.spec.ts:23,38,53
- src/architecture/helpers.ts:57 (plus detect-non-literal-fs-filename for readdirSync at :29)
- src/architecture/i18n-compliance.spec.ts:39
- src/architecture/server-logging.spec.ts:29,56
- src/architecture/ui-pattern-enforcement.spec.ts:35,47,73,91

svelte/no-navigation-without-resolve (8):
- src/lib/components/storage/landing/RecentItems.svelte:132,158,195,203,216
- src/routes/(app)/settings/connections/[id]/edit/+page.svelte:77
- src/routes/(app)/storage/+error.svelte:86
- src/routes/(app)/storage/+layout.svelte:42,45

security/detect-non-literal-regexp (1):
- e2e/storage/archive.spec.ts:174

F3l1x1vo · 2026-09-17T12:57:22Z

A lot of the Playwright tests fail for me, do they for you too?

Sometimes they do fail locally for me when developing under resource strain. This flakiness also happens in the GitHub Actions. I've hopefully improved this in b94619d.

Bohreromir · 2026-09-18T08:16:13Z

+/**
+ * Shared helpers for architecture fitness tests.
+ *
+ * ArchUnitTS only scans TypeScript (.ts) source files. Svelte (.svelte) and


Bohreromir

please do not mark my comments as resolved, I loose track of them otherwise

Bohreromir · 2026-09-22T12:27:47Z

F3l1x1vo · 2026-09-23T07:30:02Z

@Bohreromir I've implemented most of your suggestions in 9e2ec68. I have two points to address:

When creating a new file paste (ctrl+p) does not work in the filename field

Ctrl + P is not a valid shortcut. File paste works on Ctrl + V.

Fonts look very faint/smeared/weird

It's the regular bold disabled font we use everywhere. I don't disagree that it appears slightly blurred if you look closely in darkmode but it's clearly legible. This was accepted from the day we first did a mockup with the Stackable Team of the storage browser.

Bohreromir · 2026-09-23T09:10:51Z

@F3l1x1vo Whoops my bad. I meant using ctrl+v into the field for the new file name

F3l1x1vo · 2026-09-23T10:52:57Z

I meant using ctrl+v into the field for the new file name

There's a conflict there with the regular pasting of text. If the user wants to copy and paste a filename he copied from outside the browser for example, a file in the clipboard of the storage browser would be pasted into that field instead of his text. This pasting of filenames by the clipboard is a very niche and weird interaction that I would suggest to leave out.

Bohreromir

some more

Bohreromir · 2026-09-23T09:43:22Z

+if (!process.env.DATABASE_PASSWORD) {
+  log.warn('DATABASE_PASSWORD not set, using default development password');
+}
+const dbPassword = process.env.DATABASE_PASSWORD || 'cockpit-dev-password';


We should have it fail here in production if the db pw is not set, not fall back to something known

Bohreromir · 2026-09-23T12:18:58Z

+      if (!value.includes('://')) return true;
      try {
-        return new URL(v).hostname;
+        new URL(value);


z.url() should do the trick again

zod even ships ip4/6 validation

Bohreromir · 2026-09-23T12:26:29Z

+    const keysToDelete = [...new Set(succeeded.map((s) => s.sourceKey))];
+    if (keysToDelete.length > 0) {
+      await onBeforeDelete?.(keysToDelete);
+      const deleteResult = await provider.deleteObjects(keysToDelete);


operations.ts:174 + s3-provider.ts:237 — move builds its delete list from succeeded keys, but deleteObjects re-expands any key ending in /. One failed copy in a folder move and that object is deleted anyway.

Bohreromir · 2026-09-23T12:32:48Z

+
+  const db = drizzle(connectionUri);
+  await migrate(db, {
+    migrationsFolder: path.resolve('src/lib/server/migrations')


Migrations cannot run in the shipped image — src/ is never copied, npm isn't in the image, drizzle-kit and tsx are devDependencies

Bohreromir · 2026-09-23T12:33:55Z

+
+// SSL is disabled in development (local k8s), enabled in production
+const isDev = process.env.NODE_ENV !== 'production';
+const sslMode = isDev ? false : true;


where does the actual cert comes from if this is set to true? If its self signed im not sure the app will trust it

Bohreromir · 2026-09-23T12:52:22Z

+npm run db:studio          # Open Drizzle Studio (web-based DB preview/management)
+```
+
+**Override env file**: Use `DRIZZLE_ENV_FILE` to use a different environment file:


DRIZZLE_ENV_FILE=.env.production npm run db:generate

That variable is read nowhere. Grep across every .ts/.js/.json outside node_modules returns zero hits.

This is the worse of the two, because it reads as a targeting mechanism. An operator runs DRIZZLE_ENV_FILE=.env.production npm run db:migrate believing they've pointed the migration at production; the variable is ignored, and drizzle-kit migrates whatever process.env happens to hold — which, per the fallbacks above, is localhost with the dev password. It fails silently in the wrong direction: no error, no warning, just a command that didn't do what its own documentation says.

Bohreromir · 2026-09-23T13:10:18Z

+    return { entries, hasMore: false };
+  } catch (err) {
+    throw new Error(
+      'RAR support requires the "unrar" command to be installed on the server. ' +


Aren't we the ones controlling the server?
Apart from that does the unrar license says:
"UnRAR source code may be used in any software to handle
RAR archives without limitations free of charge, but cannot be
used to develop RAR (WinRAR) compatible archiver and to
re-create RAR compression algorithm, which is proprietary.
Distribution of modified UnRAR source code in separate form
or as a part of other software is permitted, provided that
full text of this paragraph, starting from "UnRAR source code"
words, is included in license, or in documentation if license
is not available, and in source code comments of resulting package."
https://github.com/pmachapman/unrar/blob/master/license.txt

I dont speak lawyer, but that might be something @lfrancke wants to check.

Honestly I'd drop the whole archive thing.

Bohreromir · 2026-09-23T13:11:52Z

+  maxBytes?: number
+): Promise<ArchiveListing> {
+  const bin = await find7zBinary();
+  if (!bin) throw new Error('7z support requires 7-Zip to be installed on the server.');


where is this installed? including it in the build has the same rar problem described above as it includes the rar archiever

Bohreromir · 2026-09-23T13:22:29Z

+   * Delete conflicting destination files before copy/move to prevent
+   * the server from auto-renaming them with " (2)" suffix.
+   */
+  private async _deleteConflictingDests(


cross-bucket paste is offered but unsupported. Replace deletes the destination file, then the copy fails.

This is because both
_performPasteSequential and _performPaste have a _sourceBucket argument but they are simply not used.

Bohreromir · 2026-09-23T13:30:08Z

+    dropSidebarTarget = null;
+  }
+
+  function handleSidebarDrop(e: DragEvent, _bucket: string, prefix: string) {


nothing uses the _bucket argument so this looks like a drag and drop over two different buckets is possible, but its not as boht move and copy only support a single bucket

dklOrdix and others added 30 commits May 4, 2026 09:18

refactor(frontend): clean up and restructure app

161ce0e

fix: add lint:fix script to package.json and clean up trailing comma …

d2de208

…in +layout.svelte

docs: update AGENTS.md to include Material UI icon library usage

c81b4d0

refactor(header): move components for header into own directory

9add069

chore: dedupe lockfile

8343022

fix(sidebar): add hover cursor style to toggle button

4bc8e93

chore(types): centralise navigation and auth types; update header/sid…

952dc80

…ebar imports Co-authored-by: Copilot <copilot@github.com>

feat(storage): initial Filebrowser UI implementation

cba7866

Co-authored-by: Copilot <copilot@github.com>

refactor(storage): extract service layer and consolidate storage type…

5de8d9f

…s/utils Co-authored-by: Copilot <copilot@github.com>

Merge branch 'feat/s3-file-browser' into feat/s3-file-browser-ui

20909ae

chore(storage): remove outdated STORAGE_REORG_PLAN.md

2b33533

fix(lint): resolve errors

aeac85d

refactor(tests): update ThemeToggle tests to use checkbox role

f2ba284

Co-authored-by: Copilot <copilot@github.com>

style: format code

af9b651

fix(tests): update theme toggle role from button to checkbox

8373974

Co-authored-by: Copilot <copilot@github.com>

fix: revert changes to Theme Toggle

7aff59b

fix: revert changes to Theme Toggle

266a045

Merge pull request #90 from stackabletech/feat/s3-file-browser-ui

805f693

feat(storage): initial Filebrowser UI implementation

#80 use pagination controls to navigate the file browser

3386182

#80 show page counter for pagination control

b77bcfa

Co-authored-by: Copilot <copilot@github.com>

#80 fix lint and svelte check

48b552e

Co-authored-by: Copilot <copilot@github.com>

fix lint error

7c9733f

Merge pull request #100 from stackabletech/feat/s3-file-browser-pagin…

9d85f57

…ation S3 File Browser Page Navigation (Pagination)

File Browser: Feature Flag (#105)

b4e25ec

* #96 disable the storage browser if feature flag is set * #96 fix svelte-check * #96 fix lint * #96 disable storage browser by default

Rename option STACKABLE_UI_COMPLETION_DISABLED (#106)

c36f1c8

S3 File Browser: Shared Pagination Component (#103)

ff43b22

* #102 refactor pagination controls into a separate component * #102 simplified pagination props

Merge branch 'main' into feat/s3-file-browser

ed9be69

Feat/s3 file browser refactor object table (#120)

184fa84

* refactor(ObjectTable): extract File and Folde rows into seperate components * style: format code * style: use camelCase * style: use camelCase

Bohreromir reviewed Sep 16, 2026

View reviewed changes

#278 implement changes suggested in code review

cc43ef3

Bohreromir requested changes Sep 17, 2026

View reviewed changes

#278 strengthen e2e tests to be less flaky

b94619d

Bohreromir requested changes Sep 17, 2026

View reviewed changes

F3l1x1vo added 8 commits September 18, 2026 08:42

#208 remove TECH_DEBT mentions

5121fcb

#208 implement changes suggested in code review

5db9aaf

#208 use eslint size limits

71d8828

#208 use eslint check-file

acda359

#208 merge db migrations

ec02386

#208 implement changes suggested in code review

17bdaa9

Merge main into feat/s3-file-browser-v1

063f694

#208 fix broken tests and lint from merge

98b4f20

Bohreromir requested changes Sep 18, 2026

View reviewed changes

Comment thread src/lib/server/storage/encryption.ts

Comment thread src/lib/storage/errors.ts Outdated

Comment thread src/lib/storage/tabs.svelte.ts Outdated

Comment thread src/lib/storage/state.svelte.ts Outdated

F3l1x1vo added 2 commits September 21, 2026 07:52

#208 implement changes suggested in code review

3cebf6d

#208 implement changes suggested in code review

895cd8f

Bohreromir requested changes Sep 21, 2026

View reviewed changes

F3l1x1vo added 2 commits September 22, 2026 06:41

#208 implement changes suggested in code review

9a8a09b

#208 remove username fallback for email

0a68c9f

Bohreromir requested changes Sep 22, 2026

View reviewed changes

Comment thread dev/modules/env.sh Outdated

Comment thread dev/modules/summary.sh Outdated

Comment thread dev/modules/postgresql.sh Outdated

Comment thread dev/modules/garage.sh Outdated

Comment thread src/lib/server/db.ts

#208 implement changes suggested in code review

d2ab0c1

#208 implement changes suggested in code review

9e2ec68

#208 fix lint

24b21e6

Bohreromir requested changes Sep 23, 2026

View reviewed changes

Uh oh!

Conversation

dklOrdix commented Jun 18, 2026 • edited by F3l1x1vo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bohreromir left a comment

Choose a reason for hiding this comment

Uh oh!

Bohreromir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

F3l1x1vo commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bohreromir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bohreromir commented Sep 22, 2026 • edited by F3l1x1vo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manage Connections

Bucketview

Preview

Uh oh!

F3l1x1vo commented Sep 23, 2026

Uh oh!

Bohreromir commented Sep 23, 2026

Uh oh!

F3l1x1vo commented Sep 23, 2026

Uh oh!

Bohreromir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dklOrdix commented Jun 18, 2026 •

edited by F3l1x1vo

Loading

F3l1x1vo commented Sep 17, 2026 •

edited

Loading

Bohreromir commented Sep 22, 2026 •

edited by F3l1x1vo

Loading