Conversation
un-lock-able
force-pushed
the
ipc-crossfire
branch
from
September 11, 2026 15:36
1cd5c5c to
3c31852
Compare
There was a problem hiding this comment.
Please re-check that in all of your changes (and also all other channel usage in our code) that we use the correct variant of spsc, mpsc and mpmc channel; Also, we prefer unbounded channels over bounded ones because they won't introduce deadlocks. If using an unbounded channel won't cause memory to grow infinitely, we shall always use the unbounded ones.
|
|
||
| // Compress possible output and upload | ||
| let (tx, mut rx) = mpsc::channel::<(ArtifactContentType, u64)>(3); | ||
| let (tx, rx) = crossfire::mpmc::bounded_async::<(ArtifactContentType, u64)>(3); |
There was a problem hiding this comment.
This actually should not be bounded as it may introduce unexpected deadlock. Please change it to unbounded channel in crossfire; Also, the channel is actually used as an spsc channel, so please switch to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpscandoneshotchannels used for internal message passing with Crossfire channels.