fix: preserve forecast learning and prepare robust EV planning - #1232
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The beta.4 audit found three Core defects: both-zero battery overrides raised known driver caps, the forecast hash change discarded compatible learning, and a stale or incomplete power balance could overwrite current-slot household load.
Keep each known battery limit in planning and dispatch. Preserve the old learning ID only when the exact beta.3 binding proves a compatible upgrade; keep that binding across restart and still invalidate it when the measurement setup changes. Use the shared qualified telemetry snapshot for live household load.
Pair with https://github.com/srcfl/energyplan/pull/27. The bundle pins Energyplan 0.4.5 at
bde1609415c132a857e1997d1422aad0ee1532fefor Linux ARM64, Linux AMD64 and macOS ARM64. EV goals share capacity across deadlines and return safe partial plans with explicit shortfall. Core validates the charger's actual pulse power and the exact energy budget. Private solver source and tests remain in Energyplan.Local validation:
make verifypasses, including native optimizer/forecast tests, fault injection, plan validation, migration tests, vet and build. New tests cover the reported defects, persistent upgrade bindings, missing flows and shared EV deadlines. A captured 193-slot site request ran on Raspberry Pi in 2.14 s; the 500 ms budget also returned a feasible plan in 0.524 s. Both planned the full EV goal. Core replay checks the hardware-produced responses separately. These are isolated worker runs, not a completed charging session.Fredrik chose local verification while the private repository's GitHub Actions account is limited. No beta has been published or installed. Merge the paired changes before preparing the next version through Changesets. Learning already overwritten by an earlier beta needs a matching backup; this change does not reconstruct lost samples.
Closes #1229. Closes #1230. Closes #1231.