fix(updater): preserve retirement output and custom service names - #1086
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c7bd7db20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Left a non-blocking comment; this automation did not approve. Cursor Bugbot completed with no findings, but the repo approval policy still requires a CODEOWNERS review. Assigned the CODEOWNER for the changed .github/ path.
Sent by Cursor Approval Agent: Pull Request Router and Approver
There was a problem hiding this comment.
Left a non-blocking comment; this automation did not approve. Cursor Bugbot completed with no findings, but the repo approval policy still requires a CODEOWNERS review rather than auto-approval. Assigned the CODEOWNER for the changed .github/ path.
Sent by Cursor Approval Agent: Pull Request Router and Approver
1 participant
The Python retirement helper used the updater's short status-log output and a fixed service name. Startup logs could hide the final error or backup path, and a renamed updater could not run retirement.
Stream the full command output, report only backups that were created, and use the image-based updater service lookup. Accept the published compatibility image as well as canonical and mirrored updater images. This fixes the follow-up findings on #1083.
make verifypassed, including a regression case with a renamed updater and mirrored image. The first beta's retirement command has also removed Python on the Pi 4; this keeps the same migration and improves its output and service lookup.