Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cursor/approval-policies/ROUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- product: ftw
boundary: /
policies:
- APPROVAL_POLICY.md
- Request GitHub reviews only from .github/CODEOWNERS for paths this PR changes. Never request erikarenhill. Do not select reviewers from commit history.
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
# This is about who gets asked, not who is allowed to contribute.

# Web/UI changes require a human visual check; see AGENTS.md.
# Do not auto-request @erikarenhill; he is not a CODEOWNER.

# Drivers and the Lua host.
/drivers/ @frahlg
Expand All @@ -15,3 +16,5 @@
/.github/ @frahlg
/AGENTS.md @frahlg
/CLAUDE.md @frahlg
/APPROVAL_POLICY.md @frahlg
/.cursor/ @frahlg
4 changes: 4 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ landed on somebody else's finished work.
badly while it waits.
- **Respect `.github/CODEOWNERS`.** An owner reviews what lands in their
area, whoever — or whatever — wrote it.
- **Do not request GitHub reviews except CODEOWNERS.** Never request
@erikarenhill and never @mention people for attention — the GitHub
Discord bot turns both into pings. See
[`APPROVAL_POLICY.md`](APPROVAL_POLICY.md).
- **Review web/UI changes in a browser.** A human must inspect the rendered
interface; AI review and reading the source code are not enough.

Expand Down
37 changes: 37 additions & 0 deletions APPROVAL_POLICY.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Review routing

Cursor's PR Routing agent has been requesting reviewers from commit
history. That pings @erikarenhill on Discord several times a day for
agent PRs he does not need to see, and it keeps doing so whether or
not he responds.

This file overrides that reviewer-selection guidance. See
[PR Routing & Approval](https://cursor.com/docs/approval-agents).

## Who to request

Request a GitHub review only from people listed in `.github/CODEOWNERS`
for a path this PR actually changes.

Do not pick reviewers from git blame, commit history, or "who else
collaborates here."

Never request @erikarenhill. He is not a CODEOWNER. A human who
actually wants his eyes can still request him by hand.

Do not @mention people in PR bodies or comments to get their
attention. The GitHub Discord bot turns those into pings too.

## When not to request anyone

If no CODEOWNERS path matches, request nobody. Web/UI changes need a
human looking at the rendered page (see AGENTS.md); that is not a
GitHub review request.

Do not re-request a reviewer on later pushes of the same PR. Once is
enough.

## Approvals

This file does not authorise auto-approving PRs. CODEOWNERS review
and the web visual check stay as they are.