refactor: clarify team-selection logic in OnJoinTeamCommand

[Rushaway]

Audit finding — OnJoinTeamCommand() readability / dead code

1. Operator-precedence footgun

if(!g_bZombieSpawned && NewTeam == CS_TEAM_T || NewTeam == CS_TEAM_NONE)

&& binds tighter than ||, so this already meant
(!g_bZombieSpawned && NewTeam == CS_TEAM_T) || NewTeam == CS_TEAM_NONE.
Added the explicit parentheses + a comment. No behaviour change — this
just makes the intent obvious and silences the compiler warning.

2. Always-true condition

if(!g_cvAliveTeamChange.BoolValue && IsPlayerAlive(client) && NewTeam >= 0 && (...))

NewTeam is validated to be within [CS_TEAM_NONE, CS_TEAM_CT] (i.e.
>= 0) earlier in the function, so NewTeam >= 0 is dead. Removed.

Noted, not changed here

The strcmp(command, "joingame") branch (lines ~274-281) is unreachable:
only "jointeam" is registered with AddCommandListener. Activating it
(registering "joingame" so the forced team-selection panel works) is a
behaviour change that deserves its own tested PR.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

One newly added comment misstates the behavior of the alive-team-change guard and should be corrected to avoid misleading future maintenance.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Refactors OnJoinTeamCommand() in TeamManager.sp to make team-selection intent clearer (explicit operator precedence in a ZR-specific condition) and remove a dead/always-true sub-condition, aligning with the stated readability audit findings.

Changes:

• Added explicit parentheses (and explanatory comment) to avoid operator-precedence ambiguity in the ZombieReloaded team-selection branch.
• Removed the redundant NewTeam >= 0 check after NewTeam is already range-validated earlier in the function.
• Updated nearby comments to describe the logic (one comment needs a small wording correction to match behavior).

File summaries

File	Description
addons/sourcemod/scripting/TeamManager.sp	Clarifies ZR team-selection condition precedence and removes a dead team-range check in OnJoinTeamCommand().

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.