fix(cookie) :: test the security attributes on a cookie - #1429
Merged
lovasoa merged 1 commit intoSep 6, 2026
Conversation
81reap
marked this pull request as ready for review
September 6, 2026 07:06
Collaborator
Author
|
CI failure is unrelated to this change, it comes from this commit on main 4c60e5d |
Nothing checked that a cookie is `HttpOnly`, `Secure`, `SameSite=Strict` and scoped to `/` by default. Nothing checked that MySQL, MSSQL, and Oracle (which have no `boolean` literal) was able to set cookie overrides with `0`. Adds tests for these cases.
lovasoa
force-pushed
the
mutation/09-2-cookie-security-attributes
branch
from
September 6, 2026 12:56
5a479a7 to
f84c801
Compare
lovasoa
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing checked that a cookie is
HttpOnly,Secure,SameSite=Strictand scoped to/by default. Nothing checked that MySQL, MSSQL, and Oracle (which have nobooleanliteral) was able to set cookie overrides with0.Adds tests for these cases.
found by #1396