fix(ci): quiet Rust test output - #1407
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The PostgreSQL matrix failure in the referenced job is difficult to diagnose because the failure output contains every passing test and a very large repeated SQL error.
Root Cause
stop_at_first_errorlogged everyDbItem::Errorwith the fullanyhowchain aterrorlevel. The same error was then handled downstream. Forerror_too_many_nested_inclusions.sql, each recursivesqlpage.run_sqlcontext was included repeatedly, producing a hugetarget=sqlpage::webserver::database::execute_queriesline. The aggregate SQL-file test attached all captured logs to one failure.Recursive errors were also wrapped again by each parent
run_sqlcall and statement-position formatter, so development error pages repeated the same context.Fix
stop_at_first_error; downstream error handling remains responsible for the error response.--quietin the database matrix, removing successful-test chatter while preserving failures and captured diagnostics.run_sqlerrors without adding repeated context.run_sql: unable to runcontext.Before
From the linked job:
After
The same failure retains the actionable test and panic while removing passing-test chatter and the duplicate recursive log:
For a recursive inclusion request in development, the response now contains one positioned error with the
Too many nested inclusionsmessage, rather than a repeatedrun_sql: unable to runchain. Production behavior remains the generic safe error response.Validation
cargo test --quietcargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningsgit diff --check