Skip to content

SOAP WS-Addressing MessageId header is always required when receiving message using Addressing10 - #1848

Merged
snicoll merged 2 commits into
spring-projects:5.0.xfrom
goutamadwant:GH-1427
Sep 11, 2026
Merged

SOAP WS-Addressing MessageId header is always required when receiving message using Addressing10#1848
snicoll merged 2 commits into
spring-projects:5.0.xfrom
goutamadwant:GH-1427

Conversation

@goutamadwant

Copy link
Copy Markdown
Contributor

WS-Addressing 1.0 requests may omit MessageID when replies are sent to the anonymous endpoint or discarded via the none endpoint. Spring WS currently defaults a missing ReplyTo to anonymous, but still treats the non-null default endpoint as requiring MessageID.

This updates the WS-Addressing 1.0 required-property check so MessageID is only required when ReplyTo or FaultTo targets a non-anonymous, non-none endpoint. The regression coverage includes explicit anonymous ReplyTo, missing ReplyTo, and none ReplyTo requests without MessageID.

Closes gh-1427

Testing:

  • ./gradlew :spring-ws-core:test --tests org.springframework.ws.soap.addressing.server.AddressingInterceptor10Tests --max-workers=2
  • ./gradlew :spring-ws-core:test --tests 'org.springframework.ws.soap.addressing.*' --max-workers=2
  • ./gradlew :spring-ws-core:test --max-workers=2
  • ./gradlew :spring-ws-core:check --max-workers=2
  • git diff --check

@snicoll
snicoll self-requested a review July 3, 2026 16:02
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 3, 2026
See spring-projectsgh-1848

Signed-off-by: Goutam Adwant <8672451+goutamadwant@users.noreply.github.com>
@snicoll snicoll changed the title Allow anonymous WS-Addressing replies without MessageID SOAP WS-Addressing MessageId header is always required when receiving message using Addressing10 Sep 11, 2026
@snicoll snicoll self-assigned this Sep 11, 2026
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 11, 2026
@snicoll snicoll added this to the 5.0.3 milestone Sep 11, 2026
@snicoll
snicoll changed the base branch from main to 5.0.x September 11, 2026 09:29
@snicoll
snicoll merged commit 048b769 into spring-projects:5.0.x Sep 11, 2026
1 check failed
@snicoll

snicoll commented Sep 11, 2026

Copy link
Copy Markdown
Member

Thanks very much @goutamadwant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SOAP WS-Addressing MessageId header is always required when receiving message using Addressing10 (http://www.w3.org/2005/08/addressing)

3 participants