Skip to content

Add HsqldbJdbcIndexedSessionRepositoryCustomizer - #3627

Open
MFAshby wants to merge 1 commit into
spring-projects:mainfrom
patientsknowbest:hsqldb-concurrent-attributes-fix
Open

Add HsqldbJdbcIndexedSessionRepositoryCustomizer#3627
MFAshby wants to merge 1 commit into
spring-projects:mainfrom
patientsknowbest:hsqldb-concurrent-attributes-fix

Conversation

@MFAshby

@MFAshby MFAshby commented Jan 22, 2026

Copy link
Copy Markdown

Similar to other relational databases, this configures the session attribute create query to perform an upsert in order not to fail in the case of concurrent requests modifying the same session attributes

Fixes: #3626

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 22, 2026
Similar to other relational databases, this configures the session attribute create query to perform an upsert in order
not to fail in the case of concurrent requests modifying the same session attributes

Fixes: spring-projects#3626
Signed-off-by: Martin Ashby <martin@ashbysoft.com>
@MFAshby
MFAshby force-pushed the hsqldb-concurrent-attributes-fix branch from 475fa48 to f16b689 Compare January 22, 2026 10:43
@jzheaux jzheaux added type: enhancement A general enhancement in: jdbc labels Sep 4, 2026
@jzheaux

jzheaux commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this — filling in the Hsqldb customizer is a nice gap to close alongside the existing MariaDB/MySQL/Oracle/Postgres/SqlServer/Db2 customizers.

One thing to fix before this can be merged: HsqldbJdbcIndexedSessionRepositoryCustomizerITests currently @Bean-registers a PostgreSqlJdbcIndexedSessionRepositoryCustomizer, not the HsqldbJdbcIndexedSessionRepositoryCustomizer this PR adds — looks like a copy/paste leftover from an existing Postgres test. As written, the test never actually exercises the new class. Could you update it to register the Hsqldb customizer so the test proves the upsert behavior for the class it's named after?

Since this adds new public API, it'll also need a milestone/main-track decision from a maintainer rather than a backport — happy to help route that once the test is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: jdbc status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Projects

None yet

3 participants