Skip to content

Bring changes from v7.12.1.1 to main - #8498

Draft
melton-jason wants to merge 9 commits into
mainfrom
v7.12.1-copy
Draft

Bring changes from v7.12.1.1 to main#8498
melton-jason wants to merge 9 commits into
mainfrom
v7.12.1-copy

Conversation

@melton-jason

@melton-jason melton-jason commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

See the PR #8487 and the two Issues it fixes: #8469 and #8494

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR
  • Add migration function to
    def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

Testing instructions taken from #8487

If you need a refresher on BatchEdit, check out the Speciforum!: BatchEdit

Testing for #8469

If you'd like a video which demonstrates the essence of the below steps, check out #8469 (comment)

  • Create a record that references a tree node that's not at the lowest rank in the tree
    • e.g., "Determine" a CollectionObject to a node at the Family level
    • Some common/example relationships that can be used:
      • (CollectionObject ->) Determination -> taxon
      • Locality -> geography
      • (CollectionObject ->) Preparation -> storage
      • Paleocontext -> biostart
  • Create a Query that will include the previously created record, at least one strictly lower rank the rank of the referenced tree node that is included in the Query Result, and no visible query filters that are at the tree rank or higher
    • e.g., If the referenced tree node is Taxon at the Family node, include one or ranks lower than Family in the tree (Genus, Species, Subspecies, etc.)
    • You can limit the number of results if needed by including Family results or higher in the filter: but make sure these higher ranks are hidden in the query results
    • For example if the record created in the first step is determined to Family, you can use the Taxon -> Family -> Contains or Taxon -> Order -> Contains, etc. filter(s) as long as the higher-level filters are checked as hidden (via the green checkmark to the right of the field)
  • Save the Query if needed and Batch Edit the Query Results
  • Make no modifications in the Data Set to known records which directly reference tree ranks that are higher than included in the Data Set (other modifications are fine if you wish to generally test BatchEdit functionality)
  • Commit the BatchEdit Data Set
  • Create a Record Set from the BatchEdit results
  • Ensure the record(s) which had relationships at the higher tree levels in the Data Set are included in the Record Set
  • Ensure the record(s) which had relationships at the higher tree levels remain unchanged
  • Please also do general BatchEdit testing if possible! 🙏
    • Particularly focusing on BatchEdit Data Sets that include trees
    • BatchEdit of multiple trees of the same type (such as multiple Taxon trees), would be greatly appreciated

Testing for #8494

  • Create a Query that contains at least one field of:
    • Locality -> latitide1
    • Locality -> longitude1
    • Locality -> latitide2
    • Locality -> longitude2
  • (Optional) Include one or more other fields of type "java.math.BigDecimal" in the Query
  • Ensure at least one field is hidden in the QueryBuilder (this field does not have to include a locality coordinate field!)
  • Run the Query and Export the Query Results to a Webportal Export
  • Unzip the Webportal Export and open the PortalData.csv file in any text viewer or editor (Notepad,
    • Alternatively, include the file in your GitHub review or send the file along with an exported Query Results to CSV to me!
  • Generally ensure the data for fields within the PortalData.csv roughly match the values of the fields within the Query Results
    • For this test you'd be looking for any fields that seem "shifted" to other nearby fields in the QueryResult.
    • For example, if CollectionObject -> text1 directly follows CollectionObject -> catalogNumber, generally make sure that the records' catalogNumbers are not in the text1 place or vice versa.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Batch Edit silently unlinking Tree relationships if rank not included in Data Set

2 participants