Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b6d8-52c2-769c-a693-81ec73b53042 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
This comment has been minimized.
This comment has been minimized.
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b6d8-52c2-769c-a693-81ec73b53042 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
approved these changes
Sep 18, 2026
marcleblanc2
left a comment
Contributor
There was a problem hiding this comment.
Tested on my phone, LGTM. I'm fine with hiding the dark mode selector because the default is auto, and my phone is set to dark mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
The mobile header gives search, version, theme, and GitHub nearly equal visual weight. Moving less-used utilities into the existing drawer reduces clutter without introducing another menu or hiding which documentation version the reader is viewing.
This does not change Algolia indexing. The indexer reads Contentlayer output and navigation data, not the rendered header or drawer. Before/after generated index output is byte-for-byte identical.
Before / after
Actual Chromium screenshots of the same homepage at a 390 × 844 CSS-pixel viewport and 2× scale, in light mode. The baseline is the unchanged PR base in a separate worktree. Development-tool badges are hidden in both captures. These are viewport checks, not physical-device tests.
Updated navigation drawer
Testing
pnpm exec tsc --noEmit— passed.pnpm exec eslint src/components/{Layout,MobileNavigation,ThemeSelector,VersionSelector}.tsx src/components/search/docsearch/DocSearchButton.tsx— passed.git diff --check— passed.node dev/algolia-index.mjs --dry-runon the baseline and changed code: each generated 14,190 records for 506 pages. Compared the complete.algoliadirectories withdiff -qr: records, page mappings, settings, and synonyms are identical. No index was published.batch changes; results returned successfully.