cleanup: drop docs/integration/img, fix GitLab integration gif - #2013
Open
marcleblanc2 wants to merge 1 commit into
Open
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
docs/integration/img/ came over in the 2023 migration from sourcegraph/sourcegraph doc/integration/img/, where the old docsite served images relative to the markdown. This site only serves public/, so none of the 29 files was ever reachable; every /docs/integration/img/* URL 404s and Cloudflare shows only bot traffic and HTML responses for that prefix over the last 32 days. 28 of the files were referenced by nothing: the editor and browser icons lost their <img> tags in the migration, and the G Suite screenshots moved to storage.googleapis.com/sourcegraph-assets/Docs/. The one live reference, docs/integration/gitlab.mdx, kept its relative img/gitlab-code-intel.gif path and has rendered a broken image since November 2023. Move that gif to public/ and point the page at it. Drop the redirect for /integration/img/disable_extension.png: it pointed at a URL the site never served. Amp-Thread-ID: https://ampcode.com/threads/T-01a0b272-e08d-75ea-a5d6-2ade32a7ddde Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This comment has been minimized.
This comment has been minimized.
Contributor
|
Direct preview links to pages changed in this PR: |
enriquegh
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/integration/img/(29 files, 4.6 MB)gitlab-code-intel.giftopublic/gitlab-native-integration.gifand pointdocs/integration/gitlab.mdxat it/integration/img/disable_extension.pngredirectWhy
docs/integration/img/came over in the first migration commit (c877488, Nov 2023) as a straight copy ofdoc/integration/img/fromsourcegraph/sourcegraph, where the old docsite served images relative to the markdown. This site only servespublic/, so nothing under that path has ever been reachable: every/docs/integration/img/*URL 404s.Cloudflare HTTP analytics for
sourcegraph.comover the last 32 days (the zone's retention limit) show ~870 estimated requests to that prefix, every one answered withtext/htmlortext/plain, none with an image. About 90% is bot/scanner traffic (bot score 0-3,.jspand script-injection paths, referrers fromdocs-legacy.sourcegraph.com/@3.34/...and4.4.sourcegraph.com/...).Of the 29 files, 28 were referenced by nothing: the editor and browser icon
<img>tags were dropped in the migration, and the G Suite screenshots were re-pointed atstorage.googleapis.com/sourcegraph-assets/Docs/(those copies are live). The one live reference,gitlab.mdxline 29, kept its relativeimg/gitlab-code-intel.gifpath and has rendered a broken image since November 2023; Cloudflare logged a real reader hitting that 404 from/docs/integration/gitlabon Aug 29.The redirect (added in 2cf9fd3) pointed at a URL the site never served.
Notes
/gitlab-native-integration.gif, matching the existingpublic/images (/aws-ami-marketplace.png,/postgres_collation_affected_customers.png). On production those root-relativesrcvalues are missing the/docsprefix; Serve site at a consistent, configurable basePath, for all deployments #1977 fixes that for all of them.pnpm run dev:/gitlab-native-integration.gifreturns200 image/gif(3.7 MB, 922x504) and/integration/gitlabrenders<img src="/gitlab-native-integration.gif">.pnpm run checkpasses (links, filenames, images).node dev/check-redirects.mjsreports nothing for the changed lines.