fix/links: Use mailto: for the support e-mail links - #1998
Draft
marcleblanc2 wants to merge 1 commit into
Draft
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
…ail hrefs [Support](support@sourcegraph.com) on the Enterprise Starter billing page resolved to /docs/pricing/plans/support@sourcegraph.com (404). The link checker skipped scheme-less e-mail addresses, so it never saw it; it now reports them with a mailto: fix. On main it flags exactly these three lines and nothing else. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0aed2-5fbe-7768-85ea-1378bf98f9ff
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Contributor
|
Direct preview links to pages changed in this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docs/pricing/plans/enterprise-starter.mdxlinks[Support](support@sourcegraph.com)three times. Withoutmailto:the browser resolves it as a relative path, so the link 404s at/docs/pricing/plans/support@sourcegraph.com.Fix
mailto:.dev/check-links.mjsnow reports a bare e-mail address used as an href, with amailto:suggestion, so the PR check catches the next one.Verification
On main the checker flags exactly those 3 lines; on this branch
pnpm run check links --check-anchors --check-self-linksreports "No dead links found" for the file.Found by the docs site audit in this Amp thread; rebuilt locally in this one.