ci: Crashed PR check scripts now warn instead of block - #1992
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
marcleblanc2
changed the title
marcleblanc2
force-pushed
the
marc/check-redirects-robust
branch
2 times, most recently
from
September 17, 2026 06:08
9e30c17 to
67c744b
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
✅ This revision breaks no redirects |
Contributor
✅ This revision introduces no broken links |
marcleblanc2
added a commit
that referenced
this pull request
Sep 17, 2026
… forms Amp-Thread-ID: https://ampcode.com/threads/T-01a0ad75-46cf-77ed-889b-438e2521bc89 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
changed the title
marcleblanc2
changed the title
marcleblanc2
enabled auto-merge (squash)
September 17, 2026 06:24
burmudar
approved these changes
Sep 17, 2026
The redirects check on #1982 posted a comment containing only its hidden marker, then failed. The PR changed src/data/redirects.ts from module.exports to export {}, and its copy of dev/check-redirects.mjs could no longer read the base branch's file. The workflow could not tell that crash (Node exits 1) from findings (also exit 1), so it treated an empty report as a finding. - check-redirects.mjs accepts both export styles, since CI runs the PR's script against the base branch too - Both check workflows classify by output: the scripts write their result in one go at the end, so a crash leaves it empty. A crash is a workflow warning; the comment, review and fail steps only run on a real result - The comment step never posts a report it does not have Amp-Thread-ID: https://ampcode.com/threads/T-01a0adcb-1b03-716a-852a-cc3746148488 Co-authored-by: Amp <amp@ampcode.com>
Same pattern as the links and redirects checks: a crash at import time exits 1 like findings do, and the report step then died on the empty findings file. Amp-Thread-ID: https://ampcode.com/threads/T-01a0adcb-1b03-716a-852a-cc3746148488 Co-authored-by: Amp <amp@ampcode.com>
A crashed check used to warn in the job log and skip commenting, so nobody would notice it was not running. Now the links, redirects, and spelling checks post (or update) their summary comment saying the check could not run on this revision, that it is a problem with the check and not the PR, and linking the job log. The check still passes. The next run that completes replaces the comment as usual. The all-clear wording no longer claims earlier findings were fixed, since the earlier comment may have been a crash notice. dev/post-spelling-review.mjs --crashed posts the spelling notice, reusing the summary upsert so a comment minimized as resolved is reopened. Amp-Thread-ID: https://ampcode.com/threads/T-01a0adcb-1b03-716a-852a-cc3746148488 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0adcb-1b03-716a-852a-cc3746148488 Co-authored-by: Amp <amp@ampcode.com>
This reverts commit d30e9f2.
Amp-Thread-ID: https://ampcode.com/threads/T-01a0adcb-1b03-716a-852a-cc3746148488 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/check-redirects-robust
branch
from
September 17, 2026 10:02
f6df330 to
b714b50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PR check script crashes, the workflow now comments that the check could not run instead of failing the PR
Unblocks #1982
Testing
run:steps locally for the crash, clean and findings pathsactionlintpasses