@solidjs/testing-library resolves @solidjs/web to the server build (isServer true) in jsdom tests under a multi-project vitest setup

[ashtonjurgens]

Environment

• @solidjs/vite-plugin 3.0.0-next.44
• vitest 5.0.1, multi-project (projects), pool: threads, isolate: false
• solid-js / @solidjs/web 2.0.0-rc.9
• @solidjs/testing-library 1.0.0-beta.3

Reproduction

A vitest config with two projects, one jsdom ("client") and one node ("server"):

test: {
  projects: [
    { test: { name: "client", environment: "jsdom", include: ["src/**/*.test.tsx"] } },
    { test: { name: "server", environment: "node", include: ["src/server/**/*.test.ts"] } },
  ],
}

In a test file, import { isServer } from "@solidjs/web" is false (correct browser build). But inside @solidjs/testing-library's render, @solidjs/web is the server build (isServer === true), so render/hydrate behave incorrectly.

Root cause

In the client/jsdom test posture the plugin injects browser into resolve.conditions (fixing inlined modules) but leaves @solidjs/web and @solidjs/testing-library externalized — and explicitly externalizes solid-js via test.server.deps.external: [/solid-js/]. Externalized modules are executed natively by Node, whose resolution conditions are ['node', 'import', 'default'] (no browser). So @solidjs/testing-library's own import { render, hydrate } from "@solidjs/web" resolves the node export (dist/server.js).

The plugin already handles the inverse case for the node/server posture by inlining /solid-js/ + /@solidjs[+/]web/, but the client posture gets no equivalent treatment.

Workaround

Inline the runtime packages so their imports resolve through Vite's browser condition:

test: {
  server: {
    deps: {
      inline: ["solid-js", "@solidjs/web", "@solidjs/testing-library"],
    },
  },
}

(deps.inline takes precedence over deps.external.)

[brenelz]

Thanks for the report. I reproduced a failure with this workspace shape on vitest@5.0.1, and the cause is different from the one described. Vitest 5 defaults test.sharedViteServer to true, so inline projects reuse the root Vite server and never run the plugin's config hook. They lose the per-project client or server posture, the jest-dom setup file, and the server.deps handling. The same config passes on Vitest 4.1.11.

Until a release includes #370, setting the option in the root config restores the Vitest 4 behavior without the deps.inline list:

test: {
  sharedViteServer: false,
  projects: [/* ... */],
}

I could not reproduce the exact symptom where only @solidjs/testing-library resolves the server build, so if it still happens with sharedViteServer: false, please share the full vitest config.

[ashtonjurgens]

Apologies, looks like this is deno only. Here's a repro https://gist.github.com/ashtonjurgens/aef5c128b4a24691493d7f2444c21117 . Of course, take the README's AI generated diagnosis/solution with a grain of salt.