NH-146315 Remove unused helper calculate_otlp_transaction_name - #847
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused ResponseTimeProcessor.calculate_otlp_transaction_name helper (and its associated unit tests) from the SolarWinds APM OpenTelemetry distribution, aligning the implementation with current usage patterns noted in PR #833 review feedback.
Changes:
- Deleted
ResponseTimeProcessor.calculate_otlp_transaction_namefromsolarwinds_apm/trace/response_time_processor.py. - Removed the now-unneeded
INTL_SWO_TRANSACTION_ATTR_MAXimport from the same module. - Removed unit tests that exclusively validated
calculate_otlp_transaction_name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
solarwinds_apm/trace/response_time_processor.py |
Removes the unused transaction-name helper and its unused constant import. |
tests/unit/test_processors/test_response_time_processor.py |
Removes unit tests that covered the deleted helper method. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tammy-baylis-swi
marked this pull request as ready for review
August 18, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noted in PR comment:
ResponseTimeProcessor.calculate_otlp_transaction_nameseems to not be used anymore. Removes it and its tests.