[Android] Resolve the button event dispatcher by react tag - #4415
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughButton press and hover events now resolve their event dispatcher from the button’s React view tag. Compatibility notes document support for older React Native versions. ChangesButton event dispatch
Mergeability Score: ⚪ Minimal · up to This localized Android change updates event-dispatcher resolution for React Native compatibility, and no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the Android RNGestureHandlerButtonViewManager event emission path to resolve the EventDispatcher using a React tag (view.id) via UIManagerHelper.getEventDispatcherForReactTag(...), aligning the button event dispatch mechanism with the API needed to support building against older React Native versions (< 0.85).
Changes:
- Switched button press event dispatch to use
UIManagerHelper.getEventDispatcherForReactTag(reactContext, this.id). - Switched hover event dispatch to use
UIManagerHelper.getEventDispatcherForReactTag(reactContext, this.id).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Description
Changes
getEventDispatcher(reactContext)togetEventDispatcherForReactTag(reactContext, this.id)in order to fix builds on RN < 0.85Test plan
Build 0.87, 0.84 and 0.83