Skip to content

Fix untranslated text and popup not closing #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mildrette wants to merge 2 commits into
base: audit-builds
Choose a base branch
from
Open

Fix untranslated text and popup not closing #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ddad79
added translation to untranslated strings
mildrette Aug 21, 2026
98b34a9
Fix translation and popup not closing on empty platforms state
mildrette Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/src/main/java/com/example/sw0b_001/ui/modals/ActivePlatformsModal.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,11 @@ fun ActivePlatformsModal(
)
)
},
onNavigateToPlatforms = onNavigateToPlatforms,
onNavigateToPlatforms = {
scope
.launch { sheetState.hide() }
.invokeOnCompletion { onNavigateToPlatforms() }
},
) { token ->
navController.navigate(
ComposeScreen(
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values-ar/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,4 +495,6 @@
<item quantity="one"><![CDATA[حسابك <b>%1$s</b>]]></item>
<item quantity="other"><![CDATA[حساباتك <b>%1$s</b>]]></item>
</plurals>
<string name="no_saved_platforms">لا توجد منصات محفوظة</string>
<string name="add_a_platform">أضف منصة</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-de/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,4 +489,6 @@
<item quantity="one"><![CDATA[Dein <b>%1$s</b>-Konto]]></item>
<item quantity="other"><![CDATA[Deine <b>%1$s</b>-Konten]]></item>
</plurals>
<string name="no_saved_platforms">Keine gespeicherten Plattformen</string>
<string name="add_a_platform">Plattform hinzufügen</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-es/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,4 +488,6 @@
<item quantity="one"><![CDATA[Tu cuenta de <b>%1$s</b>]]></item>
<item quantity="other"><![CDATA[Tus cuentas de <b>%1$s</b>]]></item>
</plurals>
<string name="no_saved_platforms">No hay plataformas guardadas</string>
<string name="add_a_platform">Agregar una plataforma</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-fa/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,4 +488,6 @@
<item quantity="one"><![CDATA[حساب <b>%1$s</b> شما]]></item>
<item quantity="other"><![CDATA[حساب‌های <b>%1$s</b> شما]]></item>
</plurals>
<string name="no_saved_platforms">بدون پلتفرم ذخیره شده</string>
<string name="add_a_platform">اضافه کردن پلتفرم</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-fr/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,4 +489,6 @@
<item quantity="one"><![CDATA[Votre compte <b>%1$s</b>]]></item>
<item quantity="other"><![CDATA[Vos comptes <b>%1$s</b>]]></item>
</plurals>
<string name="no_saved_platforms">Aucune plateforme enregistrée</string>
<string name="add_a_platform">Ajouter une plateforme</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-hi/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,4 +493,6 @@
<item quantity="one"><![CDATA[आपका <b>%1$s</b> खाता]]></item>
<item quantity="other"><![CDATA[आपके <b>%1$s</b> खाते]]></item>
</plurals>
<string name="no_saved_platforms">कोई सहेजा गया प्लेटफ़ॉर्म नहीं</string>
<string name="add_a_platform">एक प्लेटफ़ॉर्म जोड़ें</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-ko/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,4 +492,6 @@
<item quantity="one"><![CDATA[내 <b>%1$s</b> 계정]]></item>
<item quantity="other"><![CDATA[내 <b>%1$s</b> 계정]]></item>
</plurals>
<string name="no_saved_platforms">저장된 플랫폼 없음</string>
<string name="add_a_platform">플랫폼을 추가하세요</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-sn/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,4 +488,6 @@
<item quantity="one"><![CDATA[Akaunti yako ye<b>%1$s</b>]]></item>
<item quantity="other"><![CDATA[Maakaundi ako e<b>%1$s</b>]]></item>
</plurals>
<string name="no_saved_platforms">Hapana Mapuratifomu Akachengetwa</string>
<string name="add_a_platform">Wedzera Puratifomu</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-sw/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,4 +490,6 @@
<item quantity="one"><![CDATA[Akaunti yako ya <b>%1$s</b>]]></item>
<item quantity="other"><![CDATA[Akaunti zako za <b>%1$s</b>]]></item>
</plurals>
<string name="no_saved_platforms">Hakuna Mifumo Iliyohifadhiwa</string>
<string name="add_a_platform">Ongeza Jukwaa</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-tr/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,4 +491,6 @@
<item quantity="one"><![CDATA[<b>%1$s</b> hesabınız]]></item>
<item quantity="other"><![CDATA[<b>%1$s</b> hesaplarınız]]></item>
</plurals>
<string name="no_saved_platforms">Kaydedilmiş platform yok</string>
<string name="add_a_platform">Platform Ekle</string>
</resources>
2 changes: 2 additions & 0 deletions app/src/main/res/values-zh/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,4 +495,6 @@
<item quantity="one"><![CDATA[你的 <b>%1$s</b> 账户]]></item>
<item quantity="other"><![CDATA[你的 <b>%1$s</b> 个账户]]></item>
</plurals>
<string name="no_saved_platforms">没有已保存的平台</string>
<string name="add_a_platform">添加平台</string>
</resources>