Skip to content

[CRE] Remove deprecated v1 proto fields - #2349

Draft
bolekk wants to merge 1 commit into
mainfrom
proto_v1_cleanup
Draft

[CRE] Remove deprecated v1 proto fields#2349
bolekk wants to merge 1 commit into
mainfrom
proto_v1_cleanup

Conversation

@bolekk

@bolekk bolekk commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (29)

pkg/capabilities (1)
  • RemoteTargetConfig — 🗑️ Removed
pkg/capabilities.CapabilityConfiguration (6)

  • DefaultConfig — 🗑️ Removed

  • RemoteExecutableConfig — 🗑️ Removed

  • RemoteTargetConfig — 🗑️ Removed

  • RemoteTriggerConfig — 🗑️ Removed

  • RestrictedConfig — 🗑️ Removed

  • RestrictedKeys — 🗑️ Removed

pkg/capabilities.RemoteExecutableConfig (1)
  • RequestHashExcludedAttributes — 🗑️ Removed
pkg/capabilities/pb (8)

  • CapabilityConfig_RemoteExecutableConfig — 🗑️ Removed

  • CapabilityConfig_RemoteTargetConfig — 🗑️ Removed

  • CapabilityConfig_RemoteTriggerConfig — 🗑️ Removed

  • File_triggers_proto — 🗑️ Removed

  • OCRAttributedOnchainSignature — 🗑️ Removed

  • OCRTriggerEvent — 🗑️ Removed

  • OCRTriggerReport — 🗑️ Removed

  • RemoteTargetConfig — 🗑️ Removed

pkg/capabilities/pb.(*CapabilityConfig) (7)

  • GetDefaultConfig — 🗑️ Removed

  • GetRemoteConfig — 🗑️ Removed

  • GetRemoteExecutableConfig — 🗑️ Removed

  • GetRemoteTargetConfig — 🗑️ Removed

  • GetRemoteTriggerConfig — 🗑️ Removed

  • GetRestrictedConfig — 🗑️ Removed

  • GetRestrictedKeys — 🗑️ Removed

pkg/capabilities/pb.(*RemoteExecutableConfig) (1)
  • GetRequestHashExcludedAttributes — 🗑️ Removed
pkg/capabilities/pb.CapabilityConfig (4)

  • DefaultConfig — 🗑️ Removed

  • RemoteConfig — 🗑️ Removed

  • RestrictedConfig — 🗑️ Removed

  • RestrictedKeys — 🗑️ Removed

pkg/capabilities/pb.RemoteExecutableConfig (1)
  • RequestHashExcludedAttributes — 🗑️ Removed

📄 View full apidiff report

@bolekk
bolekk marked this pull request as ready for review August 29, 2026 00:30
@bolekk
bolekk requested a review from a team as a code owner August 29, 2026 00:30
@bolekk
bolekk marked this pull request as draft August 29, 2026 00:44
bolekk
bolekk commented Aug 29, 2026
View reviewed changes
Comment thread pkg/capabilities/capabilities.go
RestrictedKeys []string
// RestrictedConfig is configuration that can only be set by us; this
// takes precedence over any user-provided config.
RestrictedConfig *values.Map

@bolekk bolekk Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: still used for billing or not?

bolekk
bolekk commented Aug 29, 2026
View reviewed changes
Comment thread pkg/capabilities/capabilities.go
}

type CapabilityConfiguration struct {
DefaultConfig *values.Map

@bolekk bolekk Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: used for Vault config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DylanTinianov DylanTinianov Awaiting requested review from DylanTinianov

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bolekk