Update SecretsRequestParams CallbackID type to int32 - #2348
Merged
Conversation
Contributor
|
👋 vreff, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SecretsRequestParams API type used by the confidential relay capability by changing the CallbackID field from int to int32, aligning the request schema with a fixed-width integer type.
Changes:
- Change
SecretsRequestParams.CallbackIDtype frominttoint32.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ExecutionID string `json:"execution_id"` // 32 bytes, hex-encoded | ||
| OrgID string `json:"org_id,omitempty"` // Organization identifier for org-based secret ownership | ||
| CallbackID int `json:"callback_id,omitempty"` | ||
| CallbackID int32 `json:"callback_id,omitempty"` |
Contributor
|
cedric-cordenier
approved these changes
Aug 28, 2026
cedric-cordenier
enabled auto-merge
August 28, 2026 14:08
vreff
requested review from
agparadiso,
jmank88,
pavel-raykov and
russell-stern
August 28, 2026 14:35
russell-stern
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.