Add Stellar write max resource fee setting - #2347
Open
Krish-vemula wants to merge 2 commits into
Open
Conversation
Contributor
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new Stellar write-time configuration and a per-request Soroban resource-fee ceiling to support enforcing a maximum resource fee prior to transaction submission.
Changes:
- Extend
stellar.SubmitTransactionRequestwith aMaxResourceFeefield (stroops) intended as a per-request Soroban resource-fee ceiling. - Add CRE settings schema support for
PerWorkflow.ChainWrite.StellarincludingReportSizeLimitandMaxResourceFee. - Update generated/default settings artifacts (
defaults.toml,defaults.json) and settings documentation flowchart.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/chains/stellar/stellar.go | Adds MaxResourceFee to the domain submit-tx request type. |
| pkg/settings/cresettings/settings.go | Extends the settings schema and default values with ChainWrite.Stellar and MaxResourceFee. |
| pkg/settings/cresettings/README.md | Documents the new Stellar ChainWrite settings in the mermaid flowchart. |
| pkg/settings/cresettings/defaults.toml | Adds default TOML values for PerWorkflow.ChainWrite.Stellar and MaxResourceFee. |
| pkg/settings/cresettings/defaults.json | Adds default JSON values for PerWorkflow.ChainWrite.Stellar and MaxResourceFee. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
silaslenihan
previously approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Stellar ChainWrite settings for ReportSizeLimit and MaxResourceFee, and exposes MaxResourceFee on Stellar SubmitTransactionRequest so downstream relayers can enforce a per-request Soroban resource-fee ceiling before submit.