Skip to content

Add callback ID to the SecretsRequestParams type - #2346

Merged
pavel-raykov merged 2 commits into
mainfrom
add-callback-id
Aug 27, 2026
Merged

Add callback ID to the SecretsRequestParams type#2346
pavel-raykov merged 2 commits into
mainfrom
add-callback-id

Conversation

@vreff

@vreff vreff commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 27, 2026 17:18
@vreff
vreff requested a review from a team as a code owner August 27, 2026 17:18
@github-actions

Copy link
Copy Markdown
Contributor

👋 vreff, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

russell-stern
russell-stern previously approved these changes Aug 27, 2026
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

✅ API Diff Results - github.com/smartcontractkit/chainlink-common

✅ Compatible Changes (1)

pkg/capabilities/v2/actions/confidentialrelay.SecretsRequestParams (1)
  • CallbackID — ➕ Added

📄 View full apidiff report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the confidential relay secrets-get request parameters with a callback_id and binds it into the canonical response signature hash (while keeping hash compatibility when the field is unset/zero).

Changes:

  • Added CallbackID to SecretsRequestParams and included it in the canonical hash when non-zero.
  • Introduced writeInt helper for hashing CallbackID.
  • Added tests to ensure callback ID affects the hash when set, and is omitted from the hash when zero.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pkg/capabilities/v2/actions/confidentialrelay/types.go Adds callback_id to secrets request params and binds it into the canonical hash when non-zero.
pkg/capabilities/v2/actions/confidentialrelay/types_test.go Adds regression tests to confirm hash binding and backward-compatible omission behavior for callback_id=0.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkg/capabilities/v2/actions/confidentialrelay/types.go Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@vreff
vreff requested review from jmank88 and pavel-raykov August 27, 2026 18:00
@pavel-raykov

Copy link
Copy Markdown
Contributor

_ No description provided. _

It would be nice to have a jira/ticket for some explanation why this is needed.

@pavel-raykov
pavel-raykov added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit ffe164d Aug 27, 2026
32 of 33 checks passed
@pavel-raykov
pavel-raykov deleted the add-callback-id branch August 27, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants