Add callback ID to the SecretsRequestParams type - #2346
Conversation
|
👋 vreff, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results -
|
There was a problem hiding this comment.
Pull request overview
This PR extends the confidential relay secrets-get request parameters with a callback_id and binds it into the canonical response signature hash (while keeping hash compatibility when the field is unset/zero).
Changes:
- Added
CallbackIDtoSecretsRequestParamsand included it in the canonical hash when non-zero. - Introduced
writeInthelper for hashingCallbackID. - Added tests to ensure callback ID affects the hash when set, and is omitted from the hash when zero.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/capabilities/v2/actions/confidentialrelay/types.go | Adds callback_id to secrets request params and binds it into the canonical hash when non-zero. |
| pkg/capabilities/v2/actions/confidentialrelay/types_test.go | Adds regression tests to confirm hash binding and backward-compatible omission behavior for callback_id=0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
It would be nice to have a jira/ticket for some explanation why this is needed. |
No description provided.