fix(whiteboard): scene-key fingerprint + Spreadsheet/CSV rename + watermark KTP SEO - #192
Merged
Merged
Conversation
Promote to production: API Client tool
…eliably getSceneVersion sums element version numbers, so two different scenes with the same sum (e.g. both containing one element at version 1) were treated as identical — the dirty flag was never set and the newly-opened .excalidraw file was never auto-saved. Replaced savedVersion (number) with savedKey (string) combining version sum + element IDs + file IDs so any real scene change is always detected. Also rebase savedKey after the Excalidraw module loads to avoid false-positives from the default () => 0 stub. feat(seo): rename Spreadsheet Viewer → Spreadsheet/CSV Viewer (EN + ID) feat(seo): add watermark KTP content and FAQ to image-watermark (EN + ID)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
getSceneVersionsums element versions, so two different scenes with the same sum (e.g. two single-element drawings both at version 1) were treated as identical — the dirty flag was never set and an.excalidrawfile opened via Excalidraw's Open button was silently never auto-saved. Fixed by replacing the version-number comparison with a composite key ofversion_sum | element_IDs | file_IDs. Also rebase the key after the Excalidraw module loads to avoid false positives from the() => 0default stub.