improvement(ui): reuse shared button and focus treatments - #8187
BillLeoutsakosvl346 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
Matched before/after visual review for These are source-derived isolated fixtures using the actual EMCN Button and affected control components with synthetic labels and the same compiled product CSS. The full frames use a 960×1060 CSS viewport (1920×2120 image at 2× device scale); the closeups are captured at 2× device scale. The fixture does not exercise authenticated routes or file-download side effects. All 12 full-frame pairs (light/dark × 16px/20px root text × rest/resource hover/table keyboard focus) are pixel identical. The file tile also covers a long truncated filename and loading. The resource toggle's inherited hover text color changes, while its visible icon and activity dot set explicit colors and render identically. Light theme, selected controls and interaction states Dark theme, selected controls and interaction states Full frames at normal and enlarged root text size |
|
Current-head follow-up for the muted focus-ring helper. The helper now includes The source-derived isolated fixture was recaptured against the unchanged PR base. All 16 before/after full-frame pairs are pixel identical across light/dark themes, 16px/20px root text, rest, resource hover, table keyboard focus, and sidebar keyboard focus. The panels below include the sidebar focus state at 2× device scale. |
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |








Summary
Type of Change
Testing
22ed396, including both PostgreSQL paths.Checklist