Skip to content

improvement(ui): reuse collapsible cards for MCP tools - #8170

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-parameter-cardsfrom
codex/overrides-mcp-cards
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-parameter-cardsfrom
codex/overrides-mcp-cards

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

MCP tools now use the existing CollapsibleCard header and body instead of a restyled Button inside a local card. A new disabled prop blocks header activation and tab focus for tools without parameters while leaving independent card actions available.

Tool descriptions, issue tooltips, required/type badges and controlled expansion are preserved. Long tool names use OverflowText, and parameter content remains lazy while collapsed. The shared card uses 4px corners, its standard header/body spacing and fill, and a trailing badge slot. Disabled informational headers remain readable without opacity fading.

Validation: workspace type/import/API/lint checks, complete EMCN suite and 50consumer tests. Before/after screenshots use actual product rendering loops with local data; pointer/keyboard expansion, disabled controls and narrow/enlarged text were checked. No live MCP requests or captured issue-tooltip popup.

External full audit: 772→766 findings; all six targeted overrides removed with no new findings. Diff checker clean against the actual base.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 10:17pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable regressions identified.

Summary

This PR replaces MCP tools’ locally styled expandable buttons with the shared CollapsibleCard, preserving controlled expansion, lazy parameter rendering, issue tooltips, descriptions, and parameter badges.

  • Adds a disabled header state that blocks collapse activation and removes the header from tab order without disabling independent card actions.
  • Uses OverflowText for long tool names and the shared trailing badge slot for issue state and expansion affordances.
  • Adds focused coverage for disabled pointer and keyboard behavior.

Reviews (1) · Last reviewed commit: "improvement(ui): reuse collapsible cards..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after at 6aedeaf. Actual MCP tool rendering loops with local data/state. Expansion by pointer/Enter/Space, disabled headers and narrow text were checked; no live MCP requests. Issue-tooltip source is preserved, but the popup was not captured.

Intentional differences: shared 4px corners/header fill/spacing, trailing issue badge, and readable non-expandable headers without opacity fading.

Light, expanded — before left / after right:
clipboard

Dark, expanded — before left / after right:
clipboard

Cards — 2× enlarged crop:
clipboard

@waleedlatif1
waleedlatif1 merged commit 99ca82b into codex/control-fix-parameter-cards Sep 23, 2026
14 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-mcp-cards branch September 23, 2026 02:13

This branch was successfully deployed

1 active deployment
Preview 6aedeaf1 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants