Skip to content

improvement(ui): compose horizontal and credential fields in EMCN - #8164

Open
BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-modal-fieldsfrom
codex/overrides-field-composition
Open

BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-modal-fieldsfrom
codex/overrides-field-composition

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Horizontal modal rows and credential fields currently restyle shared controls locally. This moves label/control alignment and wrapping into ChipModalField orientation="horizontal", and monospace typography into ChipTextarea monospace. Table security and both credential/JSON consumers use these APIs.

The team URL uses the existing input prefix slot, and the MCP advanced-settings action uses the existing inline Button size. Textarea heights, validation, labels and handlers are preserved; specialized editor modals are unchanged. Narrow horizontal rows can wrap, and the URL prefix now shares the input surface.

Validation: workspace type checks, import checks, API validation, lint, full EMCN suite, and 19 consumer tests across table security, team management and workflow resume. Before/after light/dark and narrow/enlarged-text fixture screenshots will be attached; browser fixtures exercise local controls, not backend mutations.

External full audit: 854→845 findings (eight targeted component overrides plus the obsolete prefix radius). Diff checker reports only intentional shared-component definition changes; no consumer violations.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 10:01pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the shared component APIs preserve the migrated consumers’ behavior while improving narrow-layout composition.

Summary

This PR consolidates recurring field presentation into shared EMCN APIs while preserving consumer behavior.

  • Adds horizontal composition and narrow-width wrapping to ChipModalField.
  • Adds a declarative monospace option to ChipTextarea and migrates structured-text consumers.
  • Reuses existing input-adornment and inline-button APIs in team and MCP settings.
  • Updates component guidance and tests for labels, feedback, sizing, and typography.

Reviews (1) · Last reviewed commit: "improvement(ui): compose horizontal and ..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after at be663f4. Real EMCN components and equivalent consumer composition with local state; no live credential/team/permission mutations. Textarea heights remain 120/180px. The URL prefix now shares the input surface, and narrow horizontal rows wrap with enlarged text.

Light — before left / after right:
clipboard

Dark — before left / after right:
clipboard

URL prefix and advanced action — 2× crop:
clipboard

390px documents, 20px root text — horizontal rows wrap without overflow:
clipboard

This branch was successfully deployed

1 active deployment
Preview be663f4e Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant