improvement(emcn): share ordinary action geometry in Button

[BillLeoutsakosvl346]

Summary

• Extend Button with shared 28/32/40px icon sizes, responsive targets, round shape and an inline caption size. Geometry preserves the chosen colour, corner and icon-stroke treatment unless shape is explicitly selected.
• Migrate table option/filter removal actions to the shared size. Their appearance and behaviour are unchanged, including enlarged-text scaling.
• Use the shared 20px inline Button for the log file Download and table New row actions, removing seven more local overrides. Download keeps its action; New row keeps creation, blocked-state tooltip and aria-disabled guard.
• Intentional inline-action differences: Download label 11→12px; New row gains 6px padding per side and uses the ghost secondary resting text colour.
• Keep specialized bulk/composer controls in charge of their own shape.

Type of Change

• Improvement

Testing

• Full EMCN suite: 362 tests passed; table-filter suite: 14 tests passed.
• All workspace type checks, lint, repository audits, import checks and API validation passed.
• Full-source audit removes both targeted overrides with no new findings. Actual-parent diff check reports zero new usage violations; the new shared APIs are reported as intentional system changes.
• Browser comparisons cover both themes, native hover, keyboard focus, disabled controls, 390px mobile targets and enlarged text. These render actual components with local test data; authenticated table persistence is outside fixture coverage.
• The inline-action child change passed its direct full Test and Build run, 26 workspace type checks, lint, 47 audits and 368 EMCN tests. The full scan removed exactly seven targeted findings with none added; its committed diff linter reported zero findings. Matched before/after screenshots and interaction notes use synthetic data and do not exercise authenticated routes or backend persistence.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 23, 2026 12:01am UTC

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues identified.

Summary

This PR centralizes ordinary action geometry in the shared EMCN Button component and migrates table and log actions away from local sizing overrides.

• Adds shared icon sizes, responsive icon geometry, round shape, and inline caption sizing.
• Preserves specialized geometry ownership in bulk and composer action buttons.
• Adds coverage for responsive sizing, styling composition, refs, focus, submission, and disabled behavior.
• Updates EMCN component guidance to document the shared geometry API.

_{Reviews (4) · Last reviewed commit: "fix(emcn): assert responsive icon size m..."}

[cubic-dev-ai]

No issues found across 8 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[BillLeoutsakosvl346]

Before / after — actual table option and filter components with local test data. Both themes retain the same size, padding, colour, corners and icon stroke. The two closeups are 2× enlargements of the original screenshots.

Checked in Chrome with actual SelectOptionsEditor, TableFilter, and EMCN Button code in an external fixture with local test data. Light/dark, hover, keyboard focus, disabled buttons, enlarged text and narrow viewport captures are saved. The fixture is supplemental: it does not claim authenticated workspace/backend end-to-end coverage. At the standard root size both migrated actions remain 28×28px; at enlarged root text both remain 35×35px. Responsive toolbar examples retain the 40px mobile target.

Base: 13f85d82ddc8; reviewed head: d583476eed12.

[BillLeoutsakosvl346]

@greptile

[BillLeoutsakosvl346]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

All reported issues were addressed across 10 files

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[BillLeoutsakosvl346]

The small Download and New row inline Button migration arrived in this branch via #8177 (commit ce888f9). Its matched before/after screenshots and interaction notes cover both themes, row hover, and blocked keyboard focus with the tooltip. The committed diff linter reported zero findings; the full design scan removed exactly seven overrides and added none. The direct Test and Build run for the source commit passed: https://github.com/simstudioai/sim/actions/runs/35798788276. Current-head build and both reviewers are running on this parent PR.

[BillLeoutsakosvl346]

@greptile

[BillLeoutsakosvl346]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 10 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[BillLeoutsakosvl346]

@greptile

[BillLeoutsakosvl346]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 10 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}