refactor(ui): consolidate product corner radii - #8138
waleedlatif1 merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
All reported issues were addressed across 68 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Visual review 1/3 — real product screensBefore: These are browser captures of the actual application, with matching local data, theme, viewport and scroll state. Each board includes full context plus crops from the same coordinates, enlarged equally on both sides.
|
Visual review 2/3 — isolated components and source treatmentsBefore:
|
Visual review 3/3 — radius scale, validation and remaining gapsThis isolated matrix covers all 26 distinct manifest treatments using the application's compiled CSS. At the normal 16px root, the intended changes are 3→4px, 5→4px and 10→8px. The final crop row uses a 20px root: migrated fixed-pixel callers now inherit the existing central scale (xs/sm/md/lg/xl/2xl/3xl = 2/6/8/10/15/20/30px). Actual 125% Chrome zoom was also checked. Two points verified from generated CSS and browser computed styles:
Checks: all 192 targeted central-radius findings resolved; zero new diff usage violations; workspace types/lint, import and API validation passed; 2,331 existing tests passed. GitHub checks are green after rerunning an Electron teardown timeout. The combined design checkout retains the 13 planned central-radius exceptions, plus the separate 17 component-chrome radius findings deferred to later work. Incomplete live coverage: full workflow/panel and marketing-page screenshots could not be obtained reliably from the local routes. Active resume/CLI handoffs, live queued runs, remote collaborator cursors and runtime drag ghosts were not exercised end to end. Fixtures supplement appearance only; these states still need manual review. No marketing source was modified. |
2b16e72 to
5e8223b
Compare
c68b5e9 to
6f0169c
Compare
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
66e610b
into
codex/control-fix-destructive-ghost-buttons





Consolidates ordinary product corners onto the existing global radius scale across loading placeholders, chat surfaces, mentions, favicons, knowledge tags, document editing, log dashboards, workflow panels and drag previews. EMCN defaults and component APIs are unchanged.
At the normal 16px root size, the intentional differences are 3→4px, 5→4px and 10→8px. Other mapped sizes stay the same, including directional square corners and the two 1px-high dividers. The already-imported 12/16/24px Tailwind radii are declared explicitly in
globals.css. Fixed-pixel callers now follow the existing scale when root text size is enlarged.Validation:
The radius branch merges cleanly into the combined design checkout. Full live coverage of transient loading, active resume/CLI handoffs, queued runs, remote collaborator cursors and drag images is supplemented with labeled source fixtures; their complete workflows are not claimed as browser-tested. Marketing source is untouched. The workflow and marketing routes could not be reliably loaded locally for matching screenshots.
Screenshot comparisons:
GitHub CI is green after rerunning an Electron shutdown timeout.