Skip to content

refactor(ui): consolidate product corner radii - #8138

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-destructive-ghost-buttonsfrom
codex/product-corner-radii
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-destructive-ghost-buttonsfrom
codex/product-corner-radii

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Consolidates ordinary product corners onto the existing global radius scale across loading placeholders, chat surfaces, mentions, favicons, knowledge tags, document editing, log dashboards, workflow panels and drag previews. EMCN defaults and component APIs are unchanged.

At the normal 16px root size, the intentional differences are 3→4px, 5→4px and 10→8px. Other mapped sizes stay the same, including directional square corners and the two 1px-high dividers. The already-imported 12/16/24px Tailwind radii are declared explicitly in globals.css. Fixed-pixel callers now follow the existing scale when root text size is enlarged.

Validation:

  • All 192 targeted scanner findings resolved. Parent audit: 229→37 (13 preserved exceptions; 24 already handled by sibling component migrations). Disposable combined-design checkout: 13 central-radius findings, all preserved exceptions. The separate 17 component-chrome radius findings remain deferred.
  • Repository-wide reference review also migrated matching runtime style recipes and kept document/editor task checkboxes consistent. No linter or review artifacts in this diff.
  • Diff conformance check: zero new usage violations; three expected global-definition notifications.
  • All workspace type checks and lint; 53,348 import specifiers; normal and strict API validation pass.
  • 2,331 existing tests pass across EMCN, workflow renderer and relevant consumers.
  • Browser computed-radius checks cover directional corners, 16px/20px root text and 125% Chrome zoom. Before/after screenshot comments distinguish actual product screens from isolated source fixtures.

The radius branch merges cleanly into the combined design checkout. Full live coverage of transient loading, active resume/CLI handoffs, queued runs, remote collaborator cursors and drag images is supplemented with labeled source fixtures; their complete workflows are not claimed as browser-tested. Marketing source is untouched. The workflow and marketing routes could not be reliably loaded locally for matching screenshots.

Screenshot comparisons:

GitHub CI is green after rerunning an Electron shutdown timeout.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 9:12pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because no outstanding functional, security, or repository-rule issue remains.

Summary

This PR consolidates fixed border-radius values onto the shared Tailwind and CSS radius scale.

  • Replaces arbitrary pixel radii across loading states, chat surfaces, editor controls, dashboards, workflow panels, and drag previews.
  • Adds explicit xl, 2xl, and 3xl radius tokens for already-imported scale values.
  • Preserves directional square corners and other intentional exceptions.

Reviews (3) · Last reviewed commit: "refactor(ui): consolidate product corner..."

Comment thread apps/sim/app/_styles/globals.css

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 68 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Visual review 1/3 — real product screens

Before: e58eab2e5b1e · After: c68b5e9ab27c.

These are browser captures of the actual application, with matching local data, theme, viewport and scroll state. Each board includes full context plus crops from the same coordinates, enlarged equally on both sides.

  • Home composer and document editor: the existing 16px composer, 4px inline-code and 8px code-block radii retain their normal geometry. The document is local test content; its name is unrelated to this PR.
  • Log filter and dashboard: menu placement, panel geometry and content are retained. Dashboard date labels advance with real time; cursor/focus can also differ between captures.

Real composer and document before and after

Real log filter and dashboard before and after

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Visual review 2/3 — isolated components and source treatments

Before: e58eab2e5b1e · After: c68b5e9ab27c. These are labeled fixtures, not completed product workflows. The first board renders actual loading/tag components; the second uses extracted product classes/CSS in a simple fixture layout. Matching 3× crops preserve the original layout.

  • Login/signup loading field corners: 10→8px. Their 1px dividers retain the same clamped shape. Narrow login layout is included.
  • Resume, public-chat and CLI loading placeholders: existing on-scale sizes are retained. Public chat intentionally renders light even under a dark theme.
  • Knowledge type badge, favicons and document task checkboxes: 3→4px.
  • Resource mentions and queued attachment labels: 5→4px.
  • Joined workflow fields, document code/images and asymmetric selection corners: matching named variables retain their normal sizes and square corners.

Actual source component comparisons

Extracted source treatment comparisons

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Visual review 3/3 — radius scale, validation and remaining gaps

This isolated matrix covers all 26 distinct manifest treatments using the application's compiled CSS. At the normal 16px root, the intended changes are 3→4px, 5→4px and 10→8px. The final crop row uses a 20px root: migrated fixed-pixel callers now inherit the existing central scale (xs/sm/md/lg/xl/2xl/3xl = 2/6/8/10/15/20/30px). Actual 125% Chrome zoom was also checked.

Radius treatment matrix and matching crops

Two points verified from generated CSS and browser computed styles:

  • Bare rounded compiles to border-radius: 0.25rem in the baseline, giving 4px, not 8px, at the normal root. rounded-sm remains 4px there. At a 20px root this mapping is 5→6px, following the existing sm definition.
  • The three explicit global definitions preserve the already-imported Tailwind values. Declaring these centrally is an intentional, specifically approved part of this consolidation; the base radius and xs/sm/md/lg definitions are unchanged.

Checks: all 192 targeted central-radius findings resolved; zero new diff usage violations; workspace types/lint, import and API validation passed; 2,331 existing tests passed. GitHub checks are green after rerunning an Electron teardown timeout. The combined design checkout retains the 13 planned central-radius exceptions, plus the separate 17 component-chrome radius findings deferred to later work.

Incomplete live coverage: full workflow/panel and marketing-page screenshots could not be obtained reliably from the local routes. Active resume/CLI handoffs, live queued runs, remote collaborator cursors and runtime drag ghosts were not exercised end to end. Fixtures supplement appearance only; these states still need manual review. No marketing source was modified.

Base automatically changed from codex/control-fix-knowledge-tag-rows to codex/control-fix-destructive-ghost-buttons September 22, 2026 17:58
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-destructive-ghost-buttons branch from 2b16e72 to 5e8223b Compare September 22, 2026 20:47
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 68 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 68 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 66e610b into codex/control-fix-destructive-ghost-buttons Sep 23, 2026
8 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/product-corner-radii branch September 23, 2026 02:23

This branch was successfully deployed

1 active deployment
Preview 6f0169c9 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants