Skip to content

improvement(ui): share dashed add-row buttons - #8032

Open
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/control-fix-add-row-buttons
Open

BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/control-fix-add-row-buttons

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Share the identical dashed “Add filter condition” and “Add sort” actions through EMCN AddRowButton.
  • Preserve their height, typography, icon, border, callbacks, and empty/read-only conditions without adding Button variants.

Type of Change

  • Refactor

Testing

  • Workspace type checks, lint, repository audits, import/API validation, and documentation checks pass.
  • 346 EMCN tests and 99 query-builder tests pass. The new component test covers refs, activation, disabled state, and native form behavior.
  • Light/dark browser fixtures match the original markup; click, Enter, Space, and disabled states were exercised.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 19, 2026 8:48pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the extraction preserves the existing filter and sort behavior and introduces no actionable regressions.

Summary

This PR extracts the identical empty-state filter and sort actions into a shared EMCN AddRowButton.

  • Preserves the existing dashed, full-width ghost-button presentation.
  • Retains the filter and sort builders’ callbacks and read-only/empty-state conditions.
  • Exports the component through the existing EMCN barrel.
  • Adds coverage for refs, activation, disabled state, and native form submission behavior.

Reviews (1) · Last reviewed commit: "improvement(ui): share dashed add-row bu..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant