Skip to content

refactor(ui): share static API and MCP parameter cards - #8027

Open
BillLeoutsakosvl346 wants to merge 4 commits into
codex/control-fix-remaining-field-cardsfrom
codex/control-fix-parameter-cards
Open

BillLeoutsakosvl346 wants to merge 4 commits into
codex/control-fix-remaining-field-cardsfrom
codex/control-fix-parameter-cards

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

API and MCP parameter editors duplicated the same name/type header and description-card styling. They now use EMCN FieldCard, which shares its frame and body with CollapsibleCard while keeping a non-interactive, always-open header. Existing description controls, values and callbacks are preserved.

Colors, borders, corners, body spacing and badge placement stay the same. Long names use the standard fade and full-value tooltip; MCP settings names align to the other cards at 14px instead of 15px, making that header 2.5px shorter in the browser comparison. Existing collapsible cards retain their appearance and behavior.

Validation: all 26 workspace type/lint checks, import-specifier resolution, mandatory API validation, 355 EMCN tests and 45 relevant consumer tests passed. The external conformance audit removes all three targeted findings and adds none. Twelve field-control subtrees are unchanged. Isolated light/dark browser comparisons cover the migrated cards, long labels, actions and keyboard collapse/reopen; live API saves and MCP deployments were not exercised.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 20, 2026 1:28am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable correctness, security, or repository-rule violations were identified.

Summary

This PR introduces a reusable, always-open FieldCard, shares its frame and body implementation with CollapsibleCard, and migrates three API/MCP parameter editors to the shared component.

  • Preserves the existing collapsible-card interaction and accessibility contracts.
  • Preserves parameter description values, callbacks, badges, and body spacing at migrated call sites.
  • Adds focused coverage confirming that static field-card content remains visible and non-collapsible.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
    Frame[FieldCardFrame]
    Body[FieldCardContent]
    Static[FieldCard]
    Collapsible[CollapsibleCard]
    API[API parameter editor]
    MCP[MCP deploy parameter editor]
    Settings[Workflow MCP settings]

    Frame --> Static
    Body --> Static
    Frame --> Collapsible
    Body --> Collapsible
    Static --> API
    Static --> MCP
    Static --> Settings
Loading

Reviews (1) · Last reviewed commit: "refactor(ui): share static API and MCP p..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai Please review the current parameter-card changes.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai Please review the current parameter-card changes.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
* improvement(ui): share field mode toggles

* fix(ui): transition field mode icon colors

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant