Skip to content

refactor(ui): share collapsible workflow field cards - #8017

Open
BillLeoutsakosvl346 wants to merge 2 commits into
codex/control-fix-destructive-ghost-buttonsfrom
codex/control-fix-collapsible-field-cards
Open

BillLeoutsakosvl346 wants to merge 2 commits into
codex/control-fix-destructive-ghost-buttonsfrom
codex/control-fix-collapsible-field-cards

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Filter rules, sort rules, document tags and knowledge tag filters repeat the same collapsible field-card styling. Migrate them to EMCN CollapsibleCard, add a header-actions slot outside the collapse target, and forward native root attributes so workflow search can still target each row.

Card colors, borders, corners, spacing and action positions are preserved. Long titles adopt the existing fade/full-title tooltip treatment. Field controls, search highlights, refs, read-only restrictions and add/remove behavior stay in the consumers. No new visual variants are introduced.

Validation: 345 EMCN tests and 118 existing fork-sync/search-highlight tests pass, as do workspace type checks/lint, import resolution and API validation. The external audit removes all eight scoped radius findings with zero new findings. Ten light/dark fixture comparisons confirm unchanged card/body geometry and action positions, including the existing shared-card preview layout. Browser checks cover keyboard toggling and independent action clicks; full product workflow and landing integrations were not exercised. Review tooling and screenshots are outside this PR.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 20, 2026 1:22am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The current PR appears safe to merge; no actionable correctness, security, or repository-rule issue remains in the reviewed changes.

Summary

The PR consolidates document tags, filter rules, knowledge-tag filters, and sort rules onto the shared EMCN CollapsibleCard. It extends the shared component with an action slot and native root-attribute forwarding while retaining controlled collapse behavior, search hooks, read-only restrictions, and overflow-title handling.

  • Moves row actions outside the collapse trigger so add/delete controls operate independently.
  • Forwards native div attributes and workflow-search data attributes to the card root.
  • Adds coverage for mouse and keyboard toggling, root attributes, action isolation, disabled actions, and event propagation.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Consumer[Workflow field-card consumer] -->|title and collapsed state| Card[CollapsibleCard]
  Consumer -->|add/delete controls| Actions[Header actions]
  Consumer -->|data attributes and ARIA| Root[Card root]
  Card --> Trigger[Keyboard/click collapse trigger]
  Card --> Body[Expanded field controls]
  Actions -. outside collapse target .-> Trigger
Loading

Reviews (2) · Last reviewed commit: "refactor(ui): share collapsible workflow..."

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-destructive-ghost-buttons branch from 76d44d6 to 16b81b5 Compare September 19, 2026 19:51
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-collapsible-field-cards branch from 416b32f to f3a1d85 Compare September 19, 2026 19:51
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptileai @cubic-dev-ai Please review the current head. The previous scored reviews predate the base update.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@greptileai @cubic-dev-ai Please review the current head. The previous scored reviews predate the base update.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant