You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Filter rules, sort rules, document tags and knowledge tag filters repeat the same collapsible field-card styling. Migrate them to EMCN CollapsibleCard, add a header-actions slot outside the collapse target, and forward native root attributes so workflow search can still target each row.
Card colors, borders, corners, spacing and action positions are preserved. Long titles adopt the existing fade/full-title tooltip treatment. Field controls, search highlights, refs, read-only restrictions and add/remove behavior stay in the consumers. No new visual variants are introduced.
Validation: 345 EMCN tests and 118 existing fork-sync/search-highlight tests pass, as do workspace type checks/lint, import resolution and API validation. The external audit removes all eight scoped radius findings with zero new findings. Ten light/dark fixture comparisons confirm unchanged card/body geometry and action positions, including the existing shared-card preview layout. Browser checks cover keyboard toggling and independent action clicks; full product workflow and landing integrations were not exercised. Review tooling and screenshots are outside this PR.
The current PR appears safe to merge; no actionable correctness, security, or repository-rule issue remains in the reviewed changes.
Summary
The PR consolidates document tags, filter rules, knowledge-tag filters, and sort rules onto the shared EMCN CollapsibleCard. It extends the shared component with an action slot and native root-attribute forwarding while retaining controlled collapse behavior, search hooks, read-only restrictions, and overflow-title handling.
Moves row actions outside the collapse trigger so add/delete controls operate independently.
Forwards native div attributes and workflow-search data attributes to the card root.
Adds coverage for mouse and keyboard toggling, root attributes, action isolation, disabled actions, and event propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter rules, sort rules, document tags and knowledge tag filters repeat the same collapsible field-card styling. Migrate them to EMCN
CollapsibleCard, add a header-actions slot outside the collapse target, and forward native root attributes so workflow search can still target each row.Card colors, borders, corners, spacing and action positions are preserved. Long titles adopt the existing fade/full-title tooltip treatment. Field controls, search highlights, refs, read-only restrictions and add/remove behavior stay in the consumers. No new visual variants are introduced.
Validation: 345 EMCN tests and 118 existing fork-sync/search-highlight tests pass, as do workspace type checks/lint, import resolution and API validation. The external audit removes all eight scoped radius findings with zero new findings. Ten light/dark fixture comparisons confirm unchanged card/body geometry and action positions, including the existing shared-card preview layout. Browser checks cover keyboard toggling and independent action clicks; full product workflow and landing integrations were not exercised. Review tooling and screenshots are outside this PR.