Skip to content

refactor(ui): centralize compact icon button sizing in EMCN #7991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BillLeoutsakosvl346 wants to merge 5 commits into
base: staging
Choose a base branch
from
Open

refactor(ui): centralize compact icon button sizing in EMCN #7991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91bf6ae
refactor(emcn): centralize compact icon button sizing
Sep 18, 2026
8012ece
test(emcn): follow documented button test import order
Sep 18, 2026
8618d27
fix(emcn): restrict specialized action button sizing props
Sep 19, 2026
18c007a
style(test): use TSDoc for the import-order directive
Sep 19, 2026
13f85d8
improvement(ui): reuse compact buttons for message actions (#8087)
BillLeoutsakosvl346 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/sim/app/workspace/[workspaceId]/components/find-bar/find-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ export const FindBar = memo(function FindBar({
type='button'
variant='ghost'
size='icon'
className='size-6 shrink-0'
iconSize='compact'
className='shrink-0'
aria-label={showReplace ? 'Hide replace' : 'Show replace'}
aria-expanded={showReplace}
onClick={() => setShowReplace((visible) => !visible)}
Expand Down Expand Up @@ -179,7 +180,8 @@ export const FindBar = memo(function FindBar({
type='button'
variant='ghost'
size='icon'
className='size-6 shrink-0'
iconSize='compact'
className='shrink-0'
aria-label='Previous match'
title='Previous match (Shift+Enter)'
disabled={!navEnabled}
Expand All @@ -191,7 +193,8 @@ export const FindBar = memo(function FindBar({
type='button'
variant='ghost'
size='icon'
className='size-6 shrink-0'
iconSize='compact'
className='shrink-0'
aria-label='Next match'
title='Next match (Enter)'
disabled={!navEnabled}
Expand All @@ -203,7 +206,8 @@ export const FindBar = memo(function FindBar({
type='button'
variant='ghost'
size='icon'
className='size-6 shrink-0'
iconSize='compact'
className='shrink-0'
aria-label='Close find'
title='Close (Esc)'
onClick={onClose}
Expand Down
7 changes: 6 additions & 1 deletion apps/sim/app/workspace/[workspaceId]/components/message-actions/message-actions.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* @vitest-environment jsdom
*/
import { act, type ReactNode } from 'react'
import { act, type ComponentProps, type ReactNode } from 'react'
import { createRoot, type Root } from 'react-dom/client'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'

Expand All @@ -19,6 +19,11 @@ vi.mock('next/navigation', () => ({
}))

vi.mock('@sim/emcn', () => ({
Button: ({
variant,
iconSize,
...props
}: ComponentProps<'button'> & { variant?: string; iconSize?: string }) => <button {...props} />,
Check: () => null,
Duplicate: () => null,
Split: () => null,
Expand Down
31 changes: 17 additions & 14 deletions apps/sim/app/workspace/[workspaceId]/components/message-actions/message-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import { memo, useEffect, useRef, useState } from 'react'
import {
Button,
Check,
ChipModal,
ChipModalBody,
Expand All @@ -27,8 +28,6 @@ import { useForkMothershipChat } from '@/hooks/queries/mothership-chats'
import { useFolderStore } from '@/stores/folders/store'

const ICON_CLASS = 'size-[14px]'
const BUTTON_CLASS =
'flex size-[26px] items-center justify-center rounded-[6px] text-[var(--text-icon)] transition-colors hover-hover:bg-[var(--surface-hover)] focus-visible:outline-hidden'

interface MessageActionsProps {
content: string
Expand Down Expand Up @@ -162,14 +161,15 @@ export const MessageActions = memo(function MessageActions({
{canCopyContent && (
<Tooltip.Root>
<Tooltip.Trigger asChild>
<button
<Button
type='button'
aria-label='Copy message'
onClick={copyToClipboard}
className={BUTTON_CLASS}
variant='quiet'
iconSize='compact-fixed'
Comment thread
BillLeoutsakosvl346 marked this conversation as resolved.
Comment thread
BillLeoutsakosvl346 marked this conversation as resolved.
>
{copied ? <Check className={ICON_CLASS} /> : <Duplicate className={ICON_CLASS} />}
</button>
</Button>
</Tooltip.Trigger>
<Tooltip.Content side='top'>
{copied ? 'Copied message' : 'Copy message'}
Expand All @@ -180,27 +180,29 @@ export const MessageActions = memo(function MessageActions({
<>
<Tooltip.Root>
<Tooltip.Trigger asChild>
<button
<Button
type='button'
aria-label='Like'
onClick={() => handleFeedbackClick('up')}
className={BUTTON_CLASS}
variant='quiet'
iconSize='compact-fixed'
>
<ThumbsUp className={ICON_CLASS} />
</button>
</Button>
</Tooltip.Trigger>
<Tooltip.Content side='top'>Good response</Tooltip.Content>
</Tooltip.Root>
<Tooltip.Root>
<Tooltip.Trigger asChild>
<button
<Button
type='button'
aria-label='Dislike'
onClick={() => handleFeedbackClick('down')}
className={BUTTON_CLASS}
variant='quiet'
iconSize='compact-fixed'
>
<ThumbsDown className={ICON_CLASS} />
</button>
</Button>
</Tooltip.Trigger>
<Tooltip.Content side='top'>Bad response</Tooltip.Content>
</Tooltip.Root>
Expand All @@ -209,15 +211,16 @@ export const MessageActions = memo(function MessageActions({
{canFork && (
<Tooltip.Root>
<Tooltip.Trigger asChild>
<button
<Button
type='button'
aria-label='Fork in new chat'
onClick={handleFork}
disabled={forkChat.isPending}
className={cn(BUTTON_CLASS, forkChat.isPending && 'cursor-not-allowed opacity-50')}
variant='quiet'
iconSize='compact-fixed'
>
<Split className={cn(ICON_CLASS, 'rotate-90')} />
</button>
</Button>
</Tooltip.Trigger>
<Tooltip.Content side='top'>Fork in new chat</Tooltip.Content>
</Tooltip.Root>
Expand Down
9 changes: 6 additions & 3 deletions ...thership-view/components/resource-content/components/browser-session/browser-find-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ export function BrowserFindBar({ inputRef, onClose, scopeId }: BrowserFindBarPro
size='sm'
aria-label='Previous match'
disabled={!result?.matches}
className='size-[24px] shrink-0 p-0'
iconSize='compact-fixed'
className='shrink-0'
onClick={() => step('back')}
>
<ArrowUp className='size-[13px]' />
Expand All @@ -117,7 +118,8 @@ export function BrowserFindBar({ inputRef, onClose, scopeId }: BrowserFindBarPro
size='sm'
aria-label='Next match'
disabled={!result?.matches}
className='size-[24px] shrink-0 p-0'
iconSize='compact-fixed'
className='shrink-0'
onClick={() => step('forward')}
>
<ArrowDown className='size-[13px]' />
Expand All @@ -127,7 +129,8 @@ export function BrowserFindBar({ inputRef, onClose, scopeId }: BrowserFindBarPro
variant='ghost-secondary'
size='sm'
aria-label='Close find bar'
className='size-[24px] shrink-0 p-0'
iconSize='compact-fixed'
className='shrink-0'
onClick={dismiss}
>
<X className='size-[13px]' />
Expand Down
3 changes: 2 additions & 1 deletion ...workspace/[workspaceId]/tables/[tableId]/components/workflow-sidebar/workflow-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,8 @@ export function WorkflowSidebarBody({
'noopener,noreferrer'
)
}
className='absolute right-[6px] bottom-1.5 z-10 size-[24px] cursor-pointer border border-[var(--border)] bg-[var(--surface-2)] p-0 hover-hover:bg-[var(--surface-4)]'
iconSize='compact-fixed'
className='absolute right-[6px] bottom-1.5 z-10 cursor-pointer border border-[var(--border)] bg-[var(--surface-2)] hover-hover:bg-[var(--surface-4)]'
>
<SquareArrowUpRight className='size-[12px]' />
</Button>
Expand Down
9 changes: 8 additions & 1 deletion apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/action-bar/action-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import { useWorkflowStore } from '@/stores/workflows/workflow/store'
const DEFAULT_DUPLICATE_OFFSET = { x: 50, y: 50 }

const ACTION_BUTTON_STYLES = [
'size-[24px] rounded-md p-0',
'rounded-md',
'border-none bg-transparent text-[var(--text-icon)]',
'hover-hover:bg-[var(--surface-5)] hover-hover:text-[var(--text-primary)]!',
'dark:hover-hover:bg-[var(--surface-4)]',
Expand Down Expand Up @@ -472,6 +472,7 @@ export const ActionBar = memo(
}
if (canRunBlock) handleRunFromBlockClick()
}}
iconSize='compact-fixed'
className={cn(getActionButtonStyles('run'), isWorkflowRunning && 'group/run')}
disabled={!canStopWorkflow && !canRunBlock}
>
Expand Down Expand Up @@ -517,6 +518,7 @@ export const ActionBar = memo(
collaborativeBatchToggleBlockEnabled([blockId])
}
}}
iconSize='compact-fixed'
className={getActionButtonStyles('enabled')}
disabled={
isWorkflowRunning ||
Expand Down Expand Up @@ -553,6 +555,7 @@ export const ActionBar = memo(
<DropdownMenuTrigger asChild>
<Button
variant='ghost'
iconSize='compact-fixed'
className={getActionButtonStyles('color')}
disabled={
isWorkflowRunning ||
Expand Down Expand Up @@ -618,6 +621,7 @@ export const ActionBar = memo(
collaborativeBatchToggleLocked([blockId])
}
}}
iconSize='compact-fixed'
className={getActionButtonStyles('lock')}
disabled={isWorkflowRunning || disabled || (isLocked && isParentLocked)}
>
Expand Down Expand Up @@ -650,6 +654,7 @@ export const ActionBar = memo(
handleDuplicateBlock()
}
}}
iconSize='compact-fixed'
className={getActionButtonStyles('duplicate')}
disabled={isWorkflowRunning || disabled || isLocked || isParentLocked}
>
Expand Down Expand Up @@ -682,6 +687,7 @@ export const ActionBar = memo(
)
}
}}
iconSize='compact-fixed'
className={getActionButtonStyles('remove')}
disabled={
isWorkflowRunning ||
Expand Down Expand Up @@ -717,6 +723,7 @@ export const ActionBar = memo(
collaborativeBatchRemoveBlocks([blockId])
}
}}
iconSize='compact-fixed'
className={getActionButtonStyles('delete')}
disabled={isWorkflowRunning || disabled || isLocked || isParentLocked}
>
Expand Down
6 changes: 4 additions & 2 deletions ...nents/panel/components/editor/components/sub-block/components/file-upload/file-upload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ function SingleFileSelector({
aria-label='Remove file'
type='button'
variant='ghost'
className='-translate-y-1/2 absolute top-1/2 right-[28px] z-10 size-6 p-0'
iconSize='compact'
className='-translate-y-1/2 absolute top-1/2 right-[28px] z-10'
onClick={onClear}
disabled={isDeleting}
>
Expand Down Expand Up @@ -766,7 +767,8 @@ export function FileUpload({
aria-label='Remove file'
type='button'
variant='ghost'
className='-translate-y-1/2 absolute top-1/2 right-[4px] size-6 p-0'
iconSize='compact'
className='-translate-y-1/2 absolute top-1/2 right-[4px]'
onClick={(e) => handleRemoveFile(file, e)}
disabled={isDeleting}
>
Expand Down
12 changes: 8 additions & 4 deletions ...panel/components/editor/components/sub-block/components/messages-input/messages-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,8 @@ export function MessagesInput({
deleteMessage(index)
}}
disabled={disabled}
className='-my-1 -mr-1 size-6 p-0'
iconSize='compact'
className='-my-1 -mr-1'
aria-label='Delete message'
>
<Trash className='size-3' />
Expand All @@ -673,7 +674,8 @@ export function MessagesInput({
moveMessageUp(index)
}}
disabled={disabled || index === 0}
className='-my-1 -mr-1 size-6 p-0'
iconSize='compact'
className='-my-1 -mr-1'
aria-label='Move message up'
>
<ChevronUp className='size-3' />
Expand All @@ -685,7 +687,8 @@ export function MessagesInput({
moveMessageDown(index)
}}
disabled={disabled || index === currentMessages.length - 1}
className='-my-1 -mr-1 size-6 p-0'
iconSize='compact'
className='-my-1 -mr-1'
aria-label='Move message down'
>
<ChevronDown className='size-3' />
Expand All @@ -699,7 +702,8 @@ export function MessagesInput({
addMessageAfter(index)
}}
disabled={disabled}
className='-mr-1.5 -my-1 size-6 p-0'
iconSize='compact'
className='-mr-1.5 -my-1'
aria-label='Add message below'
>
<Plus className='size-3.5' />
Expand Down
3 changes: 2 additions & 1 deletion ...components/editor/components/sub-block/components/selector-combobox/selector-combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,8 @@ export function SelectorCombobox({
aria-label='Clear selection'
type='button'
variant='ghost'
className='-translate-y-1/2 absolute top-1/2 right-[28px] z-10 size-6 p-0'
iconSize='compact'
className='-translate-y-1/2 absolute top-1/2 right-[28px] z-10'
onClick={handleClear}
>
<X className='size-4 opacity-50 hover-hover:opacity-100' />
Expand Down
3 changes: 2 additions & 1 deletion .../app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,8 @@ export function Editor() {
type='button'
variant='ghost'
onClick={handleOpenChildWorkflow}
className='absolute right-[6px] bottom-1.5 z-10 size-[24px] cursor-pointer border border-[var(--border)] bg-[var(--surface-2)] p-0 hover-hover:bg-[var(--surface-4)]'
iconSize='compact-fixed'
className='absolute right-[6px] bottom-1.5 z-10 cursor-pointer border border-[var(--border)] bg-[var(--surface-2)] hover-hover:bg-[var(--surface-4)]'
>
<SquareArrowUpRight className='size-[12px]' />
</Button>
Expand Down
3 changes: 2 additions & 1 deletion ...workspace/[workspaceId]/w/components/preview/components/preview-editor/preview-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,7 +1398,8 @@ function PreviewEditorContent({
type='button'
variant='ghost'
onClick={handleExpandChildWorkflow}
className='absolute right-[6px] bottom-1.5 z-10 size-[24px] cursor-pointer border border-[var(--border)] bg-[var(--surface-2)] p-0 hover-hover:bg-[var(--surface-4)]'
iconSize='compact-fixed'
className='absolute right-[6px] bottom-1.5 z-10 cursor-pointer border border-[var(--border)] bg-[var(--surface-2)] hover-hover:bg-[var(--surface-4)]'
>
{isExecutionMode && onDrillDown ? (
<Expand className='size-[12px]' />
Expand Down
3 changes: 2 additions & 1 deletion packages/emcn/src/components/bulk-action-button/bulk-action-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ export const bulkActionButtonVariants = cva(
}
)

export interface BulkActionButtonProps extends Omit<ButtonProps, 'variant' | 'size'> {
export interface BulkActionButtonProps
extends Omit<ButtonProps, 'variant' | 'size' | 'iconPadding' | 'iconSize'> {
/** Accessible name for the icon action; tooltip content is supplied separately. */
'aria-label': string
/**
Expand Down
Loading
Loading