Skip to content

Reduce the Atlassian skills to Jira, and fix eight broken modules - #1101

Draft
johnml1135 wants to merge 5 commits into
mainfrom
atlassian-skills-fix
Draft

Reduce the Atlassian skills to Jira, and fix eight broken modules#1101
johnml1135 wants to merge 5 commits into
mainfrom
atlassian-skills-fix

Conversation

@johnml1135

@johnml1135 johnml1135 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Start here: .claude/skills/atlassian-skills/SKILL.md — the Configuration and Core Workflow sections show the shape of the whole change.

The two Atlassian skills supported Jira, Confluence and Bitbucket. FieldWorks uses Jira. Confluence and Bitbucket are gone — 4,362 deletions against 293 insertions — and nine modules that never worked are fixed.

Where to look:

  • Nine of twelve read-only modules were unusable. Eight raised NameError on import, so any read through them failed and callers reached into the write skill to do a read. The ninth, jira_projects, imported cleanly and raised an unimported NotFoundError only when a project was absent — a successful import is not evidence a module works.
  • The cause was upstream's, and upstream had already fixed it. The bug arrived in cdd1823f6 (2025-12-20) and was fixed in 0fafb48e7 (2026-02-10); d1a9bc66d vendored the pre-fix state on 2026-06-11. Our files are byte-identical to upstream at cdd1823f6 — a stale snapshot, so a re-sync would have fixed this, not reintroduced it. Upstream LT-21672: Add Tables to Word Export #14 is closed as already-fixed.
  • Confluence and Bitbucket removed to the roots — not just the script modules but their docs, config blocks, credential fields, the CQL reference, and the plumbing in _common.py. Zero references outside PROVENANCE.md. What remained was rewritten rather than left with holes, and the read-only variant lost 237 lines of function signatures that REFERENCE.md already documents.
  • Both frontmatter descriptions advertised Confluence and Bitbucket and are rewritten. An overstated description is how the wrong skill gets loaded.
  • PROVENANCE.md records two local modifications that were unlisted: TLS verification is off in three places, because jira.sil.org's certificate chain does not validate here, and the write variant's "no script changes" was untrue.

Deliberately not here: _common.py keeps check_available_skills even though only one service can now be unavailable — load-bearing for the credentials path, cheap to leave.

Verification: pyflakes reports nothing across both variants and all 16 modules import. Live through the read-only skill: jira_get_issue('LT-22723'), jira_get_transitions, and jira_get_project_versions for both a real and an absent project — the last is what the ninth fix buys, and ablating that one import turns it back into a NameError. gitlint clean. No build.ps1/test.ps1: Python utilities outside the build.

Next: review and merge. Independent of #1098/#1099/#1102; #1100 now overlaps by two lines in jira_workflow.py and jira_projects.py, so whichever merges second takes a trivial conflict.


Size before and after
Before After
atlassian-skills (md + py) ~5,900 3,325
atlassian-readonly-skills (md + py) ~4,400 2,219
Script modules per skill 17 9
Broken modules (read-only) 9 0

SKILL.md specifically: write variant 741 → 382 lines, read-only 560 → 148.

What the licence investigation found

Both skills carry license: Complete terms in LICENSE in frontmatter, which is what stopped an earlier pass from touching them at all. Checking properly:

Question Answer
Where from? https://github.com/langpingxue/atlassian-skills, vendored in d1a9bc6
Declared licence? MIT, in the upstream README
LICENSE file upstream? No. GitHub's license endpoint 404s
Copyright line anywhere? No
LICENSE file here? No — the frontmatter reference dangles in both places

MIT permits modification, so the earlier caution was unnecessary. The attribution it does ask for was missing and now exists as PROVENANCE.md in each skill. Since upstream names no copyright holder, a verbatim MIT text could not honestly be authored on their behalf; the provenance files record the declaration and its gaps instead.

This is now a hard fork. A re-sync is no longer a merge — upstream becomes a source to cherry-pick Jira fixes from. PROVENANCE.md says so.

Data Center gotchas captured while investigating

Upstream's docstrings describe Jira Cloud; SIL's instance is Data Center. Three that silently disagree, now in atlassian-skills/PROVENANCE.md:

  • assignee wants a username, not an accountId. jira_create_issue and jira_update_issue both send {"accountId": ...}, which Data Center rejects. Pass custom_fields={"assignee": {"name": "<username>"}}.
  • Affects Version is not exposed at all. Pass custom_fields={"versions": [{"name": "FW 9.3"}]}.
  • resolution cannot be set by an update — not on the edit screen; only a transition sets it.

Each was found by hitting it. They are duplicated into jira-issue/references/publish.md on #1098, where someone working an LT ticket looks first.


This change is Reviewable

confluence_comments, confluence_labels, confluence_pages, jira_agile,
jira_links, jira_projects, jira_workflow and jira_worklog all raised
NameError on import: Optional or AtlassianCredentials was referenced by
a surviving function signature but missing from the import lines. Eight
of the twelve read-only modules were therefore unreachable, and callers
had to fall back to the write skill for reads.

The read-only variant looks generated from the write variant by
stripping write functions, with the stripper also pruning those two
names. The fix restores them and nothing else. It is an upstream bug and
a re-sync will reintroduce it until reported.

Verified: all twelve modules in both skills now import, and
jira_get_transitions returns live data through the read-only skill.

Both skills gain a PROVENANCE.md recording the upstream repository, the
MIT declaration, the local modifications, and the Data Center behaviours
that upstream's Cloud-oriented docstrings get wrong. Upstream declares
MIT in its README but ships no LICENSE file and no copyright line, so
the frontmatter reference to LICENSE dangles there as well as here; it
is left unchanged to keep this copy diffable.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@johnml1135
johnml1135 marked this pull request as draft August 21, 2026 15:41
atlassian-readonly-skills/SKILL.md restated all 48 function signatures
that REFERENCE.md already documents in the same folder, 237 lines of it,
copied from the write variant. It now carries a module-to-function table
naming every function the variant has, and points at REFERENCE.md for
signatures. 560 lines to 265.

The delegation is narrower than it first looked. Only Response Data
Structures, Error Handling and Dependencies are byte-identical between
the two variants and safe to document once; Configuration, Core Workflow
and Philosophy differ, because the write variant carries write examples.
Those first two are kept here verbatim rather than delegated, and the
file says which is which.

Verified: every one of the 48 functions named here is documented in
REFERENCE.md, and the list is generated from the scripts themselves
rather than from the prose it replaces.

Refs LT-22723
@github-actions

This comment has been minimized.

@johnml1135
johnml1135 force-pushed the atlassian-skills-fix branch from 672dc33 to dcd60dd Compare August 21, 2026 15:54
PROVENANCE.md said this skill had deliberately not been compressed. It
has been, in the commit before this one, so the note now records what
changed and warns that a re-sync must re-apply it alongside the import
fix and the SIL section.

The read-only note also cites the upstream issue for the import bug now that one
exists: langpingxue/atlassian-skills#14.

Refs LT-22723

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ± 0      1 suites  ±0   11m 31s ⏱️ +31s
5 864 tests +11  5 783 ✅ +11  81 💤 ±0  0 ❌ ±0 
5 873 runs  +11  5 792 ✅ +11  81 💤 ±0  0 ❌ ±0 

Results for commit f1a4455. ± Comparison against base commit 6f72671.

♻️ This comment has been updated with latest results.

FieldWorks uses Jira and nothing else. Nothing in the repository
referenced a Confluence or Bitbucket helper, yet both skills carried
full support for them: eight script modules each, their documentation,
their configuration blocks, and their plumbing in _common.py.

Removed across both variants: the confluence_* and bitbucket_* modules,
their SKILL.md and REFERENCE.md sections, the CQL query reference, the
partial-service configuration guidance, and in _common.py the dataclass
fields, is_*_available checks, get_*_client factories and the service
branches in AtlassianConfig.from_credentials.

Streamlined what remained rather than leaving holes. Configuration is
now two short modes, SIL Data Center first, with Jira Cloud kept only
for completeness. Core Workflow, the agent-mode example and the
credentials reference were rewritten around Jira instead of having
their other two thirds cut out.

Both frontmatter descriptions claimed Confluence and Bitbucket support,
so they are rewritten too. A description that overstates what a skill
does is how the wrong skill gets loaded.

Verified: zero Confluence or Bitbucket references remain outside the
provenance notes. All 9 modules in each skill import, and a live read
against SIL Jira through the read-only skill still works.

Refs LT-22723
@johnml1135 johnml1135 changed the title Fix eight unusable modules in atlassian-readonly-skills Reduce the Atlassian skills to Jira, and fix eight broken modules Aug 21, 2026
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.36%. Comparing base (6f72671) to head (f1a4455).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   38.33%   38.36%   +0.02%     
==========================================
  Files        1507     1507              
  Lines      350580   350634      +54     
  Branches    40293    40304      +11     
==========================================
+ Hits       134410   134505      +95     
+ Misses     186941   186897      -44     
- Partials    29229    29232       +3     

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

johnml1135 added a commit that referenced this pull request Aug 29, 2026
The previous commit repaired all twelve broken modules in both vendored
Atlassian variants. That was the wrong call twice over, and this reverts it.

PR #1101 is open on branch atlassian-skills-fix and already fixes this. It goes
further: it deletes the Bitbucket and Confluence modules outright, reducing both
variants to Jira, and adds a PROVENANCE.md to each. Eleven of the fifteen files
the previous commit touched are files #1101 removes, so the repair was work
against a deletion, and would have conflicted on merge.

The stated cause was also wrong. The names were not pruned locally when we
vendored. Upstream introduced the bug in cdd1823f6 (2025-12-20) and fixed it in
0fafb48e7, "Fix missing imports in readonly variant scripts" (2026-02-10). Our
copy is byte-identical to the pre-fix upstream state, and d1a9bc6 vendored it
in 2026-06-11 -- four months after upstream had fixed it. So this is a stale
snapshot, and the correct remedy is a re-sync from upstream rather than
hand-patching, which is close to what #1101 does.

Kept from the reverted commit: one line in the read-only jira_projects.py,
which also lost NotFoundError. It is raised at :179, inside a function body, so
importing the module successfully does not prove it works -- and this branch
does claim to fix that module, because it deletes the documented workaround for
it. The other fourteen files are back to their vendored state.

This branch now touches exactly two vendored files, jira_workflow.py and
jira_projects.py, which is the minimum for deleting a workaround that named
them. Those two lines overlap #1101; whichever merges second takes a two-line
conflict.
Three corrections to this branch, one of them code.

jira_projects raised NotFoundError at :179 without importing it. Unlike the
eight modules this branch already fixed, that one does not fail at import time,
so "all nine modules import" was true and still insufficient: the module broke
only when a project was absent. Ablation confirms the import is load-bearing --
removing it again turns a clean NotFoundError response into
"NameError: name 'NotFoundError' is not defined". Found with pyflakes, which is
now named in PROVENANCE.md as the check that catches this class of bug. Also
dropped ValidationError from jira_issues, where stripping the write functions
left nothing to raise it.

The recorded cause was wrong. Both PROVENANCE.md files blamed a generator here
that prunes imports while stripping write functions -- hedged as "appears to
be", and never verified. What actually happened is that upstream shipped the
bug in cdd1823f6 (2025-12-20) and fixed it in 0fafb48e7, "Fix missing imports
in readonly variant scripts" (2026-02-10). Our files are byte-identical to
upstream at cdd1823f6, and d1a9bc6 vendored that pre-fix state on 2026-06-11,
four months after the fix existed. So this was a stale snapshot, and the note
claiming "a re-sync will reintroduce it" had it backwards: a re-sync would have
fixed it. Upstream issue #14 was filed against the stale copy and is closed as
already-fixed. What does still hold upstream is the relative import in the four
bitbucket modules, which is moot here now that they are gone.

Two local modifications were unlisted, in a section that opens by asking for
them to be listed. _common.py turns TLS verification off in three places where
upstream leaves it on -- deliberate, because jira.sil.org's certificate chain
does not validate here, so the reason is now recorded rather than left as a
silent diff. And the write variant claimed "no script changes" while this
branch strips Confluence and Bitbucket plumbing out of its _common.py and
__init__.py.

Verified: pyflakes reports nothing at all across both variants, all sixteen
modules import, and jira_get_project_versions was called against live Jira for
both a real project and an absent one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants