feat: add jakubkrehel/make-interfaces-feel-better to SKILLS.txt - #210
shunkakinoki wants to merge 1 commit into
Conversation
Install-all (omit skills list) so make sync pulls every skill in the repo, currently make-interfaces-feel-better. Co-authored-by: Shun Kakinoki <shunkakinoki@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe skill configuration adds the ChangesSkill configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The skill repository entry is configured for install-all behavior and is correctly placed in the list, with no remaining merge-readiness risk identified. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="SKILLS.txt">
<violation number="1" location="SKILLS.txt:101">
P2: This change adds an install-all repo to SKILLS.txt but does not update skills-lock.json, so `make sync` / `make skills-install` will not actually pull the new skill. Per the Makefile, `skills-install` installs from `skills-lock.json` (the lock iterates `.skills` entries; it never reads SKILLS.txt directly), and `skills-lock.json` currently has no entry for `jakubkrehel/make-interfaces-feel-better` (confirmed by grep: only `juxt/allium`, `vercel-labs/before-and-after`, `dmmulroy/anti-slop`, `kunchenguid/no-mistakes` etc. are present). The README workflow for adding a skill is: edit SKILLS.txt, run `make skills-install`, and commit both files. Because this is an install-all (no-selection) repo, it also needs the one-time bootstrap `bunx skills add jakubkrehel/make-interfaces-feel-better --global --yes --skill '*'`, then `make skills-lock` to regenerate and commit the lock. As committed, the stated goal ('make sync / skills-install pulls every skill in that repo') is not achieved.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| Jakubantalik/transitions.dev transitions-dev,transitions-polish | ||
|
|
||
| # jakubkrehel/make-interfaces-feel-better (1 total) - keep all | ||
| jakubkrehel/make-interfaces-feel-better |
There was a problem hiding this comment.
P2: This change adds an install-all repo to SKILLS.txt but does not update skills-lock.json, so make sync / make skills-install will not actually pull the new skill. Per the Makefile, skills-install installs from skills-lock.json (the lock iterates .skills entries; it never reads SKILLS.txt directly), and skills-lock.json currently has no entry for jakubkrehel/make-interfaces-feel-better (confirmed by grep: only juxt/allium, vercel-labs/before-and-after, dmmulroy/anti-slop, kunchenguid/no-mistakes etc. are present). The README workflow for adding a skill is: edit SKILLS.txt, run make skills-install, and commit both files. Because this is an install-all (no-selection) repo, it also needs the one-time bootstrap bunx skills add jakubkrehel/make-interfaces-feel-better --global --yes --skill '*', then make skills-lock to regenerate and commit the lock. As committed, the stated goal ('make sync / skills-install pulls every skill in that repo') is not achieved.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At SKILLS.txt, line 101:
<comment>This change adds an install-all repo to SKILLS.txt but does not update skills-lock.json, so `make sync` / `make skills-install` will not actually pull the new skill. Per the Makefile, `skills-install` installs from `skills-lock.json` (the lock iterates `.skills` entries; it never reads SKILLS.txt directly), and `skills-lock.json` currently has no entry for `jakubkrehel/make-interfaces-feel-better` (confirmed by grep: only `juxt/allium`, `vercel-labs/before-and-after`, `dmmulroy/anti-slop`, `kunchenguid/no-mistakes` etc. are present). The README workflow for adding a skill is: edit SKILLS.txt, run `make skills-install`, and commit both files. Because this is an install-all (no-selection) repo, it also needs the one-time bootstrap `bunx skills add jakubkrehel/make-interfaces-feel-better --global --yes --skill '*'`, then `make skills-lock` to regenerate and commit the lock. As committed, the stated goal ('make sync / skills-install pulls every skill in that repo') is not achieved.</comment>
<file context>
@@ -97,6 +97,9 @@ inference-sh/skills web-search,agent-browser,agent-ui
Jakubantalik/transitions.dev transitions-dev,transitions-polish
+# jakubkrehel/make-interfaces-feel-better (1 total) - keep all
+jakubkrehel/make-interfaces-feel-better
+
# juxt/allium (6 total) - keep all
</file context>
2 participants
Add
jakubkrehel/make-interfaces-feel-betteras install-all (omit skills list) somake sync/ skills-install pulls every skill in that repo (currentlymake-interfaces-feel-better).Requested after https://x.com/jakubkrehel/status/2095538355165344214 which links https://github.com/jakubkrehel/make-interfaces-feel-better.
Inserted alphabetically after
Jakubantalik/transitions.devand beforejuxt/allium.Summary by cubic
Adds
jakubkrehel/make-interfaces-feel-bettertoSKILLS.txtsomake syncpulls all skills from that repo, currentlymake-interfaces-feel-better.Written for commit 1d7bfc2. Summary will update on new commits.