Fix Debian CI. - #1719
Open
silverhadch wants to merge 2 commits into
Open
Conversation
silverhadch
force-pushed
the
master
branch
3 times, most recently
from
August 22, 2026 10:36
bc32658 to
78d6a09
Compare
ikerexxe
reviewed
Aug 24, 2026
ikerexxe
left a comment
ikerexxe
left a comment
Collaborator
There was a problem hiding this comment.
I think this PR is mixing two separate improvements that should be handled differently:
- The main fix (addresses the immediate issue):
- DESTDIR staging to avoid
/sbin/nologincollision - The new tar-based installation logic
- Adding the missing configuration files
- Error handling modernization (general improvement):
- Switching from
ignore_errors: truetoregister + failed_when: false - Adding
stderrredirection to log captures - The deferred failure checking at the end
Suggested approach:
- Separate commit for the error handling improvements, since they're valuable but unrelated to the collision fix
- Port the error handling changes to other distributions: fedora.yml, alpine.yml and opensuse.yml. They would benefit from the same improved logging and failure detection
This would make the changes easier to review and test.
make install fails with "File exists" on /sbin/nologin, which the base image already provides. Install into /tmp/rootfs instead, remove the files that would be overwritten, and extract the tree over /. Signed-off-by: Hadi Chokr <hadichokr@icloud.com>
The build steps used ignore_errors, which keeps the play going but also lets the job report success when configure, make, or make check failed. Register each step with failed_when: false instead, so the logs are still collected, and assert at the end that every step returned 0. Also send stderr to the per-step logs, fetch the new logs, and don't abort the fetch on a missing one: a log does not exist if the step that writes it never ran. Signed-off-by: Hadi Chokr <hadichokr@icloud.com>
Comment on lines
-75
to
-77
| - name: Install | ||
| ansible.builtin.command: | ||
| make install |
Collaborator
There was a problem hiding this comment.
make install fails with "File exists" on /sbin/nologin
Why does it fail? Doesn't make install overwrite whatever is on the system? That's what I'd have expected.
Collaborator
There was a problem hiding this comment.
I second these questions. If make install is failing we should fix the root cause in the Makefile itself rather than adding workarounds in the Ansible role. Fixing it at the build level keeps the toolchain clean and independent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make install doesn't want to override /sbin/nologin so we shall force it.