Tests: Add system tests for groupadd in test_groupadd.py - #1693
Open
asakure wants to merge 4 commits into
Open
Conversation
asakure
marked this pull request as ready for review
July 23, 2026 15:01
asakure
force-pushed
the
system_tests_groupadd_22_23_24
branch
from
August 26, 2026 06:02
cbb8850 to
d010ea7
Compare
ikerexxe
reviewed
Aug 26, 2026
asakure
force-pushed
the
system_tests_groupadd_22_23_24
branch
3 times, most recently
from
August 27, 2026 08:28
8b0a946 to
0c8cf07
Compare
ikerexxe
reviewed
Aug 27, 2026
Comment on lines
+503
to
+504
| shadow.groupadd() | ||
| assert exc_info.value.rc == 2, f"Expected return code 2(invalid usage), got {exc_info.value.rc}" |
Collaborator
There was a problem hiding this comment.
Add an empty line between these two
Comment on lines
+50
to
+51
| args_list = shlex.split(args[0][0] if args[0] else "") | ||
| name = args_list[-1] if args_list else "" |
Collaborator
There was a problem hiding this comment.
args[0][0] takes the first character of the argument, not the whole argument string.
I think a good approach would be to have the defensive programming first and then handle the parsing:
if not args or not args[0]:
return {"name": ""}
args_list = shlex.split(args[0])
name = args_list[-1] if args_list else ""
Contributor
Author
There was a problem hiding this comment.
Hi @ikerexxe with this change, test fails with error:
FAILED tests/test_groupadd_working.py::test_groupadd__no_group (shadow) - IndexError: tuple index out of range
I think an additional change would be required here:
shadow/tests/system/framework/roles/shadow.py
Line 233 in 5e7ae07
| @pytest.mark.topology(KnownTopology.Shadow) | ||
| def test_groupadd__usage(shadow: Shadow): | ||
| """ | ||
| :title: Groupadd command displays usage with -h option and exits successfully |
Collaborator
There was a problem hiding this comment.
Let's avoid using -h option and only state what the test does display usage
| :setup: | ||
| 1. None required | ||
| :steps: | ||
| 1. Run groupadd command with -h option |
Collaborator
There was a problem hiding this comment.
No need to mention with -h option, as that's the how
| 1. None required | ||
| :steps: | ||
| 1. Run groupadd command with -h option | ||
| 2. Verify that groupadd command exits successfully |
Collaborator
There was a problem hiding this comment.
You are missing an additional step here: Check usage information
| 1. Run groupadd command with -h option | ||
| 2. Verify that groupadd command exits successfully | ||
| :expectedresults: | ||
| 1. Command shows usage help |
Collaborator
There was a problem hiding this comment.
I'd say this should be Command runs successfully
| 2. Verify that groupadd command exits successfully | ||
| :expectedresults: | ||
| 1. Command shows usage help | ||
| 2. groupadd command completes successfully and displays usage information |
Collaborator
There was a problem hiding this comment.
In this step you are checking that the command run successfully, thus update the message accordingly
| :expectedresults: | ||
| 1. Command shows usage help | ||
| 2. groupadd command completes successfully and displays usage information | ||
| :customerscenario: False |
Collaborator
There was a problem hiding this comment.
Missing another step here to Check usage information
| ) | ||
| def test_groupadd__invalid_usage(shadow: Shadow, args: str): | ||
| """ | ||
| :title: Groupadd command fails with invalid usage |
| 1. Run groupadd command with invalid arguments | ||
| 2. Verify that groupadd command fails | ||
| :expectedresults: | ||
| 1. Command with invalid argument fails |
Collaborator
There was a problem hiding this comment.
I'd say this should be Attempt to create groups or something similar
This is Python transformation of the test located in `tests/grouptools/groupadd/22_groupadd_usage/groupadd.test` which checks that `groupadd` command shows usage with -h option. Signed-off-by: Akshay Sakure <asakure@redhat.com>
This patch fixes the issue in shadow.py file to handle empty or missing arguments in _parse_args and groupadd so shadow.groupadd() does not raise TypeError or IndexError. Signed-off-by: Akshay Sakure <asakure@redhat.com>
This is Python transformation of the test located in `tests/grouptools/groupadd/23_groupadd_no_groups/groupadd.test` which checks that `groupadd` fails when no groupname is mentioned. Signed-off-by: Akshay Sakure <asakure@redhat.com>
This is Python transformation of the test located in `tests/grouptools/groupadd/24_groupadd_2_groups/groupadd.test` which checks that `groupadd` command fails when two groupnames are mentioned. It also parametrize python tests 23 and 24 into single test. Signed-off-by: Akshay Sakure <asakure@redhat.com>
asakure
force-pushed
the
system_tests_groupadd_22_23_24
branch
from
August 27, 2026 15:04
0c8cf07 to
e632b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add system tests for groupadd in test_groupadd.py for
existing bash tests with numbering 22, 23, 24.