fix(deps): pin dependency versions in Cargo.toml - #534
Merged
Conversation
alejandro-vaz
self-requested a review
August 31, 2026 17:15
alejandro-vaz
approved these changes
Aug 31, 2026
Collaborator
|
thanks for contributing |
Member
|
What is the motivation here? This is an unusual practice. |
Collaborator
|
to make sure that dependency requirements don't change between patch versions it seems that's what happened to technically 0.7 would have sufficed, but it seemed a version requiring rustc 1.86+ was published as a patch or something along those lines, so after the 0.7 download (which required 1.80 at publish time) some dep updated it's version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.tomlto their exact versions fromCargo.lock.Problem
Cargo.tomluses loose dependency versions, which can allow automatic patch updates and cause unexpected issues.Solution
=x.y.zversions matchingCargo.lock.Related
Closes #532