test(agent-surfaces): cover status-block, text-block, block-header - #1087
Merged
Merged
Conversation
Adds direct/dedicated test coverage for three agent-surfaces block renderers that previously only got thin single-path exercise via surface-panel.test.tsx: - block-header.test.tsx: title/count/description gating, including the count===0 vs truthiness distinction - status-block.test.tsx: tone defaulting, timestamp presence/absence (relative text + absolute title attr), detail markdown gating - text-block.test.tsx: neutral-vs-toned branch selection, toned callout classes, title/description gating within the toned branch 18 tests, mutation-tested (all observable mutants killed). Reviewed by a general-purpose agent (verdict: SHIP); trimmed one flagged redundant test with no unique mutation-kill value. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
selfcontained
deleted the
agt_6ef4df7f551c/job-test-enforcer-5610a27b
branch
September 15, 2026 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recurring test-enforcer maintenance run. Local suite was green on first pass (44th consecutive) — no failures, no flakes to triage. Added coverage for the highest-value gap flagged by the previous run's
next_focus.Changes
Direct/dedicated tests for three
apps/web/src/components/app/agent-surfaces/blocks/renderers that previously only got thin single-path exercise viasurface-panel.test.tsx:block-header.test.tsx— title/count/description gating, including thecount === 0vs truthiness distinction (count is a real falsy value, not "absent").status-block.test.tsx— tone defaulting to neutral, timestamp presence/absence (relative text + absolute on thetitleattribute), detail-markdown gating.text-block.test.tsx— neutral-vs-toned branch selection, toned callout classes, title/description gating within the toned branch.18 tests total. Mutation-tested against both components: every behavior-changing mutant (conditional branches, tone/class sourcing, attribute wiring) was killed; two DOM-presence gaps found mid-battery (a "gated markdown node still renders empty" survivor in both
block-header.tsxandstatus-block.tsx's detail-guard, andtext-block.tsx's title/description guards) were fixed by asserting on the wrapper element's absence, not just its text.Reviewed by a general-purpose agent scoped to only this diff (verdict: SHIP); one flagged redundant test with no unique mutation-kill value was trimmed.
Test plan
pnpm run check— cleanpnpm run format— cleanpnpm run test— server 187f/3321t, web 133f/1942t (+3 files/+18 tests), extension 9f/60t, all greenpnpm run finalize:web— build succeedspnpm run test:e2e— 198 passed / 12 skipped (unchanged)pnpm run test:e2e:live— 11 passed, no straye2e-*tmux sessionsCI scan
Checked the last 50 CI runs. All failures were pre-existing, branch-specific issues on one unrelated in-flight WIP branch (
agt_683b115bc1e9/dispatch-harness-research's own PR-body session-link policy violation) — no cross-branch flakes observed.🤖 Generated with Claude Code