Conversation
Drop-in SecKit security scan (gitleaks, trufflehog, osv, semgrep, checkov) on push to main and pull requests. Soft-fail: findings become a warning plus a report artifact.
There was a problem hiding this comment.
🟡 Changes recommended
The workflow currently pulls unpinned external code at runtime and uses a hard-coded Homebrew path, creating avoidable security and reliability risks.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a SecKit-based security scanning workflow to run on pushes to main and on pull requests, and exposes the scan status via a README badge.
Changes:
- Added a new GitHub Actions workflow to install SecKit scanners and run scans, uploading a markdown report artifact.
- Added a SecKit badge to the repository README.
File summaries
| File | Description |
|---|---|
README.md |
Adds a “Scanned with SecKit” badge link. |
.github/workflows/seckit-scan.yml |
New CI workflow to clone SecKit, install scanners, run scans (soft-fail), and upload the report artifact. |
Review details
Suppressed comments (1)
.github/workflows/seckit-scan.yml:55
- Same as above: avoid hard-coding the Homebrew path in the scan step; detect
brewfrom PATH so the step remains portable across runner image updates.
run: |
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" 2>/dev/null || true
bash "$RUNNER_TEMP/sec-kit/seckit.sh" scan "$GITHUB_WORKSPACE" --skip=socket
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+42
to
+43
| - name: Get SecKit | ||
| run: git clone --depth 1 https://github.com/segraef/sec-kit.git "$RUNNER_TEMP/sec-kit" |
Comment on lines
+46
to
+48
| run: | | ||
| eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" 2>/dev/null || true | ||
| bash "$RUNNER_TEMP/sec-kit/seckit.sh" install --all -y |
Comment on lines
+65
to
+68
| - name: Gate | ||
| if: steps.scan.outcome == 'failure' | ||
| run: | | ||
| echo "::warning::SecKit reported findings - download the seckit-report artifact to triage." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop-in SecKit security scan (gitleaks, trufflehog, osv, semgrep, checkov) on push to main and pull requests. Soft-fail: findings become a warning plus a report artifact. Badge in README (renders once segraef/sec-kit#feat/ci-badge is merged).