feat: recognize message.timestamp.after.max.ms and before.max.ms settings - #264
Open
pratikmallya wants to merge 1 commit into
Open
Conversation
…ings These Kafka 3.6+ topic configs bound how far a message timestamp can diverge from broker time in either direction. topicctl's config validator didn't have entries for them, so any topic YAML explicitly setting these keys failed with "not recognized topic config setting" even though brokers (including Confluent Cloud) support and return them (see segmentio#191). Add validators using the same non-negative int64 pattern as sibling settings like delete.retention.ms.
Author
|
@petedannemann @hhahn-tw not sure how notification works for this repo, the codeowners seem to point to a team that doesn't exist, just tagging y'all from the commit history, apologies if that isn't the right process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These Kafka 3.6+ topic configs bound how far a message timestamp can
diverge from broker time in either direction. topicctl's config
validator didn't have entries for them, so any topic YAML explicitly
setting these keys failed with "not recognized topic config setting"
even though brokers (including Confluent Cloud) support and return
them (see #191).
Add validators using the same non-negative int64 pattern as sibling
settings like delete.retention.ms.
upstream docs: https://docs.confluent.io/platform/current/installation/configuration/topic-configs.html#message-timestamp-after-max-ms and https://docs.confluent.io/platform/current/installation/configuration/topic-configs.html#message-timestamp-before-max-ms
Testing
built and run this locally. The error message changed from:
to
which is expected (this is before apply)