Upgrade aws-sdk v2 to @aws-sdk/client-s3 v3

[AnkitSegment]

Summary

• Migrate scripts/upload-assets.js from the monolithic aws-sdk v2 to the modular @aws-sdk/client-s3 v3 package
• Reduces devDependency footprint by only installing the S3 client module instead of the entire AWS SDK
• Reapplies the migration originally shipped in Upgrade aws-sdk v2 to @aws-sdk/client-s3 v3  #844 and reverted in Revert "Upgrade aws-sdk v2 to @aws-sdk/client-s3 v3 " #847

Why the revert happened

#844 bundled the SDK migration together with a Buildkite CI image bump (Node 12 -> Node 20), since @aws-sdk/client-s3 requires a newer Node runtime than the CI image had. That combined change broke the master merge build on the old segment/analytics-dot-js-integrations Buildkite pipeline, so it was reverted in #847.

Since then, this repo's Buildkite pipeline has migrated to Twilio's org (twilio/cdp-analytics-dot-js-integrations), and .buildkite/pipeline.yml on master already runs on NODE_BROWSER_IMAGE (Node 22). That removes the original blocker, so this PR only touches the SDK usage itself — no CI pipeline/image changes.

Changes

scripts/upload-assets.js

• Replace require('aws-sdk/clients/s3') with const { S3Client, PutObjectCommand } = require('@aws-sdk/client-s3')
• Use new S3Client({ region, credentials: { ... } }) instead of new S3({ accessKeyId, secretAccessKey, sessionToken, region })
• Replace s3.putObject(params).promise() with s3.send(new PutObjectCommand(params)) throughout (putObject helper + 2 manifest uploads)

package.json

• Replace "aws-sdk": "^2.760.0" with "@aws-sdk/client-s3": "^3.1098.0" in devDependencies

yarn.lock

• Regenerated via yarn install; no leftover aws-sdk v2 entries

Test plan

• node -c scripts/upload-assets.js — syntax check passes
• S3Client, PutObjectCommand, and client.send() verified to instantiate/work at runtime on Node 22
• Confirmed no aws-sdk@ v2 entry remains in yarn.lock
• Buildkite CI on the correct (Twilio) pipeline passes

🤖 Generated with Claude Code

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Migrate the asset upload script from AWS SDK v2 (aws-sdk) to the modular AWS SDK v3 S3 client (@aws-sdk/client-s3) to reduce dependency footprint and reapply the previously reverted SDK migration.

Changes:

• Update scripts/upload-assets.js to use S3Client + PutObjectCommand and client.send() instead of s3.putObject().promise()
• Replace aws-sdk with @aws-sdk/client-s3 in package.json devDependencies
• Regenerate yarn.lock to reflect the new dependency graph with AWS SDK v2 removed

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
scripts/upload-assets.js	Switch S3 upload implementation from AWS SDK v2 to v3 command-based client API.
package.json	Swap devDependency from aws-sdk to @aws-sdk/client-s3.
yarn.lock	Update lockfile to remove aws-sdk v2 and add AWS SDK v3 transitive dependencies.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

[mdkhan-tw]

Could you please add why we are making the change?
Could you add some testing artefact here?