Compatibility with Familiar: the two recordings endpoints it calls - #62
Open
jeffcrouse wants to merge 1 commit into
Open
jeffcrouse wants to merge 1 commit into
jeffcrouse wants to merge 1 commit into
Conversation
The list is what protects an endpoint, and it was two behind: Familiar's
ADR-0115 backfill has called POST /v1/recordings/claims since 2026-09-14,
and its ADR-0119 (2026-09-16) asks GET /v1/recordings/{mbid} before the
hash, per ADR-0019 point 3, and sends recording_mbid on contribute. The
fields it reads off a recording row are named so a change to
RecordingEmbedding is checked against them. Verified against the sibling
checkout's community_cache.py: nine request sites.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tmmn6LQjCyksB1jfaAqnhn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE.mdonly. The "Compatibility with Familiar" list is what protects an endpoint, and it was two behind:POST /v1/recordings/claims— Familiar'sADR-0115backfill has called it since 2026-09-14 (that's where the 89.6% named rows came from).GET /v1/recordings/{mbid}?type=musicbrainz_recording&pipeline_version=…— Familiar'sADR-0119(merged and deployed 2026-09-16, ADR-0119: the corpus is asked by recording before it is asked by hash (accepted, built) familiar#320) asks the recording first and the hash only on a 404, perADR-0019point 3, and now sendsrecording_mbidonPOST /v1/embeddings. The fields it reads off a recording row are named, so a change toRecordingEmbeddinggets checked against them.Verified against the sibling checkout's
community_cache.pyrather than from memory — nine request sites, all now listed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tmmn6LQjCyksB1jfaAqnhn