Skip to content

Ignore the request checksum when creating a delete marker #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maeldonn wants to merge 2 commits into
base: development/9.4
Choose a base branch
from
+562 −234
Open

Ignore the request checksum when creating a delete marker #6267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f63bb8
Reformat files with prettier
maeldonn Aug 31, 2026
06ea87b
Ignore the request checksum when creating a delete marker
maeldonn Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions lib/api/apiUtils/object/createAndStoreObject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,14 +322,19 @@ function createAndStoreObject(
}
}

const headerChecksum = areChecksumsEnabled() ? getChecksumDataFromHeaders(request.headers) : null;
if (headerChecksum && headerChecksum.error) {
return next(arsenalErrorFromChecksumError(headerChecksum));
// A delete marker has no body and no checksum: an

@DarkIsDude DarkIsDude Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is very long, I would try to extract logic to a new function. It's nits but this function are a nightmare to debug and follow.

// x-amz-checksum-* header describes the request payload
// (e.g. a multi-object delete XML).
let checksums = { primary: null, secondary: null };
if (!isDeleteMarker) {
const headerChecksum = areChecksumsEnabled()
? getChecksumDataFromHeaders(request.headers)
: null;
if (headerChecksum && headerChecksum.error) {
return next(arsenalErrorFromChecksumError(headerChecksum));
}
checksums = { primary: headerChecksum || defaultChecksumData, secondary: null };
}
const checksums = {
primary: headerChecksum || defaultChecksumData,
secondary: null,
};
return dataStore(
objectKeyContext,
cipherBundle,
Expand Down
2 changes: 1 addition & 1 deletion lib/api/multiObjectDelete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ function getObjMetadataAndDelete(
overheadField,
log,
's3:ObjectRemoved:DeleteMarkerCreated',
(err, result) => callback(err, objMD, deleteInfo, result.versionId),
(err, result) => callback(err, objMD, deleteInfo, result?.versionId),
);
},
],
Expand Down
Loading
Loading